Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool panics after receiving an UpdateChannel message #712

Closed
GitGab19 opened this issue Jan 8, 2024 · 3 comments · Fixed by #727 or #733
Closed

Pool panics after receiving an UpdateChannel message #712

GitGab19 opened this issue Jan 8, 2024 · 3 comments · Fixed by #727 or #733
Assignees
Labels
Milestone

Comments

@GitGab19
Copy link
Collaborator

GitGab19 commented Jan 8, 2024

Pool panics after an UpdateChannel message is received, and takes to a TargetError(NegativeInput).
It seems that something should be implemented in the code yet.
The line of interest is roles/pool/src/lib/mining_pool/mod.rs:192:17.

Here's a screenshot of the error, for a better context:
Screenshot 2024-01-08 at 11 33 46

@pavlenex pavlenex added this to the MVP3 milestone Jan 16, 2024
@plebhash
Copy link
Collaborator

@GitGab19 any tips on how to reproduce this error?

@GitGab19
Copy link
Collaborator Author

@GitGab19 any tips on how to reproduce this error?

I got it sometimes while testing with asic miner.
The translator automatically adjusts downstream difficulty in order to set the target share_per_minute set in the config file.
But at the same time, it modifies also the upstream difficulty.
If the miner stops working, the upstream difficulty can become negative.

I dig into it and I will open a PR to fix this tomorrow

@plebhash
Copy link
Collaborator

ok, let me know if you need help, I can try to reproduce and find a solution as well

GitGab19 added a commit to GitGab19/stratum that referenced this issue Jan 22, 2024
@GitGab19 GitGab19 linked a pull request Jan 22, 2024 that will close this issue
GitGab19 added a commit to GitGab19/stratum that referenced this issue Jan 25, 2024
@GitGab19 GitGab19 linked a pull request Jan 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants