Translator difficulty management FIX #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fi3
reviewed
Jan 22, 2024
| @@ -108,6 +108,9 @@ impl<'a> SubmitSharesError<'a> { | |||
| pub fn difficulty_too_low_error_code() -> &'static str { | |||
| "difficulty-too-low" | |||
| } | |||
| pub fn invalid_job_id_error_code() -> &'static str { | |||
There was a problem hiding this comment.
I would add the new error code in the doc comment of SubmitShareError and in the spec (just for reference)
There was a problem hiding this comment.
Done.
Also opened a PR to add it to specs (stratum-mining/sv2-spec#67)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the automatic difficulty management on the Translator.
I added some modulators which better set the downstream difficulty.
I also added a check before the channel hashrate update (which is read by upstream), to avoid it goes negative.
In this way issue #712 should be fixed by this PR.
In addiction to that, I added a check which compares the job_ids after the shares submit operation. If they are different (because a share is submitted right after a new job is sent to the miner) a more explanatory message is printed instead of the too generic and wrong
difficulty-too-lowmessage.Closes #712