enforce no_std for all? protocol/v2 crates
#1230
Conversation
|
Bencher Report| Branch | 1230/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 2,073.00 | 📈 view plot | 473.00 | 📈 view plot | 733.00 | 📈 view plot | 9.00 | 📈 view plot | 37.00 |
| client_sv2_handle_message_mining | 📈 view plot | 8,178.00 | 📈 view plot | 2,137.00 | 📈 view plot | 3,158.00 | 📈 view plot | 38.00 | 📈 view plot | 138.00 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 6,263.00 | 📈 view plot | 1,750.00 | 📈 view plot | 2,548.00 | 📈 view plot | 22.00 | 📈 view plot | 103.00 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 14,694.00 | 📈 view plot | 4,694.00 | 📈 view plot | 6,754.00 | 📈 view plot | 48.00 | 📈 view plot | 220.00 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 27,746.00 | 📈 view plot | 10,645.00 | 📈 view plot | 15,506.00 | 📈 view plot | 89.00 | 📈 view plot | 337.00 |
| client_sv2_open_channel | 📈 view plot | 4,413.00 | 📈 view plot | 1,461.00 | 📈 view plot | 2,158.00 | 📈 view plot | 10.00 | 📈 view plot | 63.00 |
| client_sv2_open_channel_serialize | 📈 view plot | 14,024.00 | 📈 view plot | 5,064.00 | 📈 view plot | 7,324.00 | 📈 view plot | 38.00 | 📈 view plot | 186.00 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 22,832.00 | 📈 view plot | 8,040.00 | 📈 view plot | 11,687.00 | 📈 view plot | 87.00 | 📈 view plot | 306.00 |
| client_sv2_setup_connection | 📈 view plot | 4,659.00 | 📈 view plot | 1,502.00 | 📈 view plot | 2,274.00 | 📈 view plot | 15.00 | 📈 view plot | 66.00 |
| client_sv2_setup_connection_serialize | 📈 view plot | 16,134.00 | 📈 view plot | 5,963.00 | 📈 view plot | 8,659.00 | 📈 view plot | 46.00 | 📈 view plot | 207.00 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 35,670.00 | 📈 view plot | 14,888.00 | 📈 view plot | 21,880.00 | 📈 view plot | 98.00 | 📈 view plot | 380.00 |
|
| Branch | 1230/merge |
| Testbed | sv1 |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| client-submit-serialize | 📈 view plot | 6,748.30 |
| client-submit-serialize-deserialize | 📈 view plot | 7,707.10 |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | 📈 view plot | 8,377.50 |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | 📈 view plot | 943.45 |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | 📈 view plot | 675.37 |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | 📈 view plot | 262.34 |
| client-sv1-get-authorize/client-sv1-get-authorize | 📈 view plot | 156.57 |
| client-sv1-get-submit | 📈 view plot | 6,451.40 |
| client-sv1-get-subscribe/client-sv1-get-subscribe | 📈 view plot | 289.67 |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | 📈 view plot | 812.52 |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | 📈 view plot | 607.60 |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | 📈 view plot | 222.88 |
|
| Branch | 1230/merge |
| Testbed | sv1 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot | 8,304.00 | 📈 view plot | 3,663.00 | 📈 view plot | 5,114.00 | 📈 view plot | 8.00 | 📈 view plot | 90.00 |
| get_submit | 📈 view plot | 95,226.00 | 📈 view plot | 59,263.00 | 📈 view plot | 85,076.00 | 📈 view plot | 49.00 | 📈 view plot | 283.00 |
| get_subscribe | 📈 view plot | 7,871.00 | 📈 view plot | 2,758.00 | 📈 view plot | 3,831.00 | 📈 view plot | 17.00 | 📈 view plot | 113.00 |
| serialize_authorize | 📈 view plot | 12,041.00 | 📈 view plot | 5,240.00 | 📈 view plot | 7,281.00 | 📈 view plot | 14.00 | 📈 view plot | 134.00 |
| serialize_deserialize_authorize | 📈 view plot | 24,452.00 | 📈 view plot | 9,786.00 | 📈 view plot | 13,787.00 | 📈 view plot | 40.00 | 📈 view plot | 299.00 |
| serialize_deserialize_handle_authorize | 📈 view plot | 30,171.00 | 📈 view plot | 11,989.00 | 📈 view plot | 16,951.00 | 📈 view plot | 61.00 | 📈 view plot | 369.00 |
| serialize_deserialize_handle_submit | 📈 view plot | 126,220.00 | 📈 view plot | 73,117.00 | 📈 view plot | 104,760.00 | 📈 view plot | 120.00 | 📈 view plot | 596.00 |
| serialize_deserialize_handle_subscribe | 📈 view plot | 27,761.00 | 📈 view plot | 9,577.00 | 📈 view plot | 13,521.00 | 📈 view plot | 69.00 | 📈 view plot | 397.00 |
| serialize_deserialize_submit | 📈 view plot | 114,825.00 | 📈 view plot | 67,894.00 | 📈 view plot | 97,370.00 | 📈 view plot | 68.00 | 📈 view plot | 489.00 |
| serialize_deserialize_subscribe | 📈 view plot | 23,052.00 | 📈 view plot | 8,129.00 | 📈 view plot | 11,427.00 | 📈 view plot | 43.00 | 📈 view plot | 326.00 |
| serialize_submit | 📈 view plot | 99,505.00 | 📈 view plot | 61,325.00 | 📈 view plot | 87,940.00 | 📈 view plot | 52.00 | 📈 view plot | 323.00 |
| serialize_subscribe | 📈 view plot | 11,176.00 | 📈 view plot | 4,111.00 | 📈 view plot | 5,696.00 | 📈 view plot | 18.00 | 📈 view plot | 154.00 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1230 +/- ##
==========================================
+ Coverage 19.36% 25.13% +5.76%
==========================================
Files 164 20 -144
Lines 10811 1134 -9677
==========================================
- Hits 2094 285 -1809
+ Misses 8717 849 -7868
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Georges760
force-pushed
the
std_logic
branch
3 times, most recently
from
03a2dae
to
fc640a7
Compare
There was a problem hiding this comment.
While I think the general idea is very welcome, I think addressing #1200 first would make more sense as it can potentially change how we approach this. I think in #1200 we should aim to provide a logger for std and no std env and then impl Debug manually, which would allow us to remove the debug feature IIUC whats going here
|
Current
So it's pseudo
Maybe this can be discussed in #1132 ? |
If I do it before #1200, when #1200 will remove |
Georges760
changed the title
no_std for all protocol/v2 cratesno_std for all? protocol/v2 crates
Yea I think #1200 shouldn't necessarily be about removing |
Georges760
force-pushed
the
std_logic
branch
3 times, most recently
from
dfb23fe
to
8ef9d5e
Compare
|
Actual This PR is not fixing this. CI does not see it because does not test it. |
|
Actual This PR is not fixing this. CI does not see it because does not test it. |
|
@Georges760 please note that we're aiming to deprecate I cannot give you a precise timeline but Q1 2025 would be my rough guess. I wonder if that would make this process simpler? |
It make sense, as it is already broken in binary_sv2 and framing_sv2 as stated above. So I understand the official/only codec way will be the "core" option ? Good |
|
So I stop here for this PR and open for reviews. |
| @@ -19,6 +19,9 @@ | |||
| //! Seq0255 <-> SEQ0_255[T] | |||
| //! Seq064K <-> SEQ0_64K[T] | |||
| //! ``` | |||
|
|
|||
| #![cfg_attr(feature = "no_std", no_std)] | |||
There was a problem hiding this comment.
We can now use #![no_std], and I'm confident that we are not using any std-compliant methods in binary_codec_sv2 in any of the top-level crates that depend on it. Since almost all of our crates are no_std-compliant, makes sense to have no-serde-sv2 to no-std only. cc: @rrybarczyk
There was a problem hiding this comment.
I asked about this in this comment.
Current binary_codec_sv2 has a broken std support, do we want to remove it or fix it ?
Look like you propose to remove it. It is also my preference.
There was a problem hiding this comment.
I also think we should enforce no_std on the protocols crates. So let's remove.
There was a problem hiding this comment.
This PR looks good to me and is ready to go. We can enforce the no-std restriction during our protocol refactoring effort, once we have more concrete reasoning for removing std-related imports. However, I’m fine with either approach.
There was a problem hiding this comment.
Agree. Let's confirm in the dev meet before we approve.
- only feature `debug` will add `std` dep which is not used by any other crates - just had to replace `std::hint` by its `core` equivalent - in `debug` removed a `mut` to clear a warning
- std::vec::Vec -> alloc::vec::Vec
- std::mem -> core::mem
- std::slice -> core::slice
- std::convert::{TryFrom, TryInto} -> core::convert::{TryFrom, TryInto}
- std::format -> alloc::format
- std::vec::Vec -> alloc::vec::Vec
- std::string::{String, ToString} -> alloc::string::{String, ToString}
no need any feature for `std` stuff, there is none
- std::vec::Vec -> alloc::vec::Vec
|
completely removing |
if I understand correctly, we should expect this PR to leave all but I'm confused: why are we still leaving some crates with the
shouldn't |
|
following this criteria, we should bump the |
That is the end goal yes
I didn't consider subprotocols/* crates either in this PR
details here above
YES totally, but this PR being multi crate already, try to limit its action to not refactor any code, just remove |
exact, but usually the version bump is done in a separate PR/commit to merge multiple improvement in a single version increment. Should I do it in this PR anyway ? |
you're right, we can leave it for a new PR |
|
@Georges760 could you please add a comment to the crates some crates are missing a for the crates that are missing a later, we're going to finish the |
|
| Branch | std_logic |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| client-submit-serialize | 📈 view plot 🚷 view threshold | 6,753.30 (-1.44%) | 9,314.18 (72.51%) |
| client-submit-serialize-deserialize | 📈 view plot 🚷 view threshold | 7,671.70 (-1.17%) | 10,337.28 (74.21%) |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 8,195.80 (-1.90%) | 11,221.66 (73.04%) |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 898.90 (-0.44%) | 1,234.36 (72.82%) |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | 📈 view plot 🚷 view threshold | 702.36 (-0.13%) | 1,011.05 (69.47%) |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | 📈 view plot 🚷 view threshold | 247.04 (-0.48%) | 275.73 (89.59%) |
| client-sv1-get-authorize/client-sv1-get-authorize | 📈 view plot 🚷 view threshold | 159.33 (+1.19%) | 166.80 (95.52%) |
| client-sv1-get-submit | 📈 view plot 🚷 view threshold | 6,554.50 (-0.85%) | 9,121.75 (71.86%) |
| client-sv1-get-subscribe/client-sv1-get-subscribe | 📈 view plot 🚷 view threshold | 278.44 (-0.07%) | 335.87 (82.90%) |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 742.61 (-2.97%) | 993.77 (74.73%) |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | 📈 view plot 🚷 view threshold | 610.13 (-2.00%) | 847.81 (71.97%) |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | 📈 view plot 🚷 view threshold | 202.84 (-1.32%) | 231.84 (87.49%) |
|
| Branch | std_logic |
| Testbed | sv2 |
🚨 7 ALERTS: Threshold Boundary Limits exceeded!
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) | Upper Boundary (Limit %) |
|---|---|---|---|---|---|
| client_sv2_mining_message_submit_standard_serialize | L2 Accesses accesses | 📈 plot 🚨 alert 🚷 threshold | 54.00 (+23.78%) | 53.93 (100.14%) | |
| client_sv2_mining_message_submit_standard_serialize_deserialize | Estimated Cycles estimated cycles | 📈 plot 🚨 alert 🚷 threshold | 27,826.00 (+1.07%) | 27,744.72 (100.29%) | |
| client_sv2_mining_message_submit_standard_serialize_deserialize | Instructions instructions | 📈 plot 🚨 alert 🚷 threshold | 10,645.00 (+0.64%) | 10,638.14 (100.06%) | |
| client_sv2_mining_message_submit_standard_serialize_deserialize | L1 Accesses accesses | 📈 plot 🚨 alert 🚷 threshold | 15,501.00 (+0.72%) | 15,484.71 (100.11%) | |
| client_sv2_mining_message_submit_standard_serialize_deserialize | L2 Accesses accesses | 📈 plot 🚨 alert 🚷 threshold | 92.00 (+13.23%) | 89.87 (102.37%) | |
| client_sv2_open_channel_serialize_deserialize | L2 Accesses accesses | 📈 plot 🚨 alert 🚷 threshold | 90.00 (+21.39%) | 85.23 (105.60%) | |
| client_sv2_setup_connection_serialize_deserialize | Estimated Cycles estimated cycles | 📈 plot 🚨 alert 🚷 threshold | 35,750.00 (+0.55%) | 35,745.38 (100.01%) |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result estimated cycles (Result Δ%) | Upper Boundary estimated cycles (Limit %) | Instructions | Benchmark Result instructions (Result Δ%) | Upper Boundary instructions (Limit %) | L1 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot 🚷 view threshold | 2,163.00 (+3.37%) | 2,205.43 (98.08%) | 📈 view plot 🚷 view threshold | 473.00 (-0.10%) | 490.80 (96.37%) | 📈 view plot 🚷 view threshold | 733.00 (-0.41%) | 760.98 (96.32%) | 📈 view plot 🚷 view threshold | 6.00 (+8.17%) | 14.27 (42.05%) | 📈 view plot 🚷 view threshold | 40.00 (+5.37%) | 41.13 (97.26%) |
| client_sv2_handle_message_mining | 📈 view plot 🚷 view threshold | 8,208.00 (-0.01%) | 8,298.83 (98.91%) | 📈 view plot 🚷 view threshold | 2,137.00 (-0.03%) | 2,143.08 (99.72%) | 📈 view plot 🚷 view threshold | 3,158.00 (-0.09%) | 3,170.64 (99.60%) | 📈 view plot 🚷 view threshold | 37.00 (+3.52%) | 42.71 (86.63%) | 📈 view plot 🚷 view threshold | 139.00 (-0.08%) | 141.15 (98.48%) |
| client_sv2_mining_message_submit_standard | 📈 view plot 🚷 view threshold | 6,357.00 (+1.22%) | 6,387.17 (99.53%) | 📈 view plot 🚷 view threshold | 1,750.00 (-0.06%) | 1,769.03 (98.92%) | 📈 view plot 🚷 view threshold | 2,547.00 (-0.28%) | 2,579.96 (98.72%) | 📈 view plot 🚷 view threshold | 20.00 (+17.76%) | 24.81 (80.60%) | 📈 view plot 🚷 view threshold | 106.00 (+1.88%) | 106.98 (99.09%) |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot 🚷 view threshold | 14,820.00 (+0.55%) | 14,996.55 (98.82%) | 📈 view plot 🚷 view threshold | 4,694.00 (-0.02%) | 4,713.03 (99.60%) | 📈 view plot 🚷 view threshold | 6,745.00 (-0.20%) | 6,785.54 (99.40%) | 📈 view plot 🚨 view alert 🚷 view threshold | 54.00 (+23.78%) | 53.93 (100.14%) | 📈 view plot 🚷 view threshold | 223.00 (+0.54%) | 228.54 (97.58%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot 🚨 view alert 🚷 view threshold | 27,826.00 (+1.07%) | 27,744.72 (100.29%) | 📈 view plot 🚨 view alert 🚷 view threshold | 10,645.00 (+0.64%) | 10,638.14 (100.06%) | 📈 view plot 🚨 view alert 🚷 view threshold | 15,501.00 (+0.72%) | 15,484.71 (100.11%) | 📈 view plot 🚨 view alert 🚷 view threshold | 92.00 (+13.23%) | 89.87 (102.37%) | 📈 view plot 🚷 view threshold | 339.00 (+1.11%) | 342.17 (99.07%) |
| client_sv2_open_channel | 📈 view plot 🚷 view threshold | 4,451.00 (+1.06%) | 4,632.44 (96.08%) | 📈 view plot 🚷 view threshold | 1,461.00 (-0.03%) | 1,478.80 (98.80%) | 📈 view plot 🚷 view threshold | 2,156.00 (-0.17%) | 2,187.48 (98.56%) | 📈 view plot 🚷 view threshold | 11.00 (+20.65%) | 17.96 (61.25%) | 📈 view plot 🚷 view threshold | 64.00 (+1.87%) | 68.89 (92.90%) |
| client_sv2_open_channel_serialize | 📈 view plot 🚷 view threshold | 14,066.00 (-0.06%) | 14,491.35 (97.06%) | 📈 view plot 🚷 view threshold | 5,064.00 (-0.01%) | 5,081.80 (99.65%) | 📈 view plot 🚷 view threshold | 7,321.00 (-0.06%) | 7,355.03 (99.54%) | 📈 view plot 🚷 view threshold | 40.00 (+13.88%) | 43.21 (92.57%) | 📈 view plot 🚷 view threshold | 187.00 (-0.43%) | 199.79 (93.60%) |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot 🚷 view threshold | 22,912.00 (+1.08%) | 22,916.56 (99.98%) | 📈 view plot 🚷 view threshold | 8,040.00 (+0.27%) | 8,075.38 (99.56%) | 📈 view plot 🚷 view threshold | 11,682.00 (+0.15%) | 11,756.45 (99.37%) | 📈 view plot 🚨 view alert 🚷 view threshold | 90.00 (+21.39%) | 85.23 (105.60%) | 📈 view plot 🚷 view threshold | 308.00 (+1.38%) | 312.64 (98.52%) |
| client_sv2_setup_connection | 📈 view plot 🚷 view threshold | 4,723.00 (+0.80%) | 4,777.66 (98.86%) | 📈 view plot 🚷 view threshold | 1,502.00 (-0.03%) | 1,519.80 (98.83%) | 📈 view plot 🚷 view threshold | 2,273.00 (-0.26%) | 2,303.05 (98.70%) | 📈 view plot 🚷 view threshold | 14.00 (+52.38%) | 15.70 (89.16%) | 📈 view plot 🚷 view threshold | 68.00 (+0.81%) | 69.97 (97.18%) |
| client_sv2_setup_connection_serialize | 📈 view plot 🚷 view threshold | 16,202.00 (+0.13%) | 16,488.88 (98.26%) | 📈 view plot 🚷 view threshold | 5,963.00 (-0.01%) | 5,980.80 (99.70%) | 📈 view plot 🚷 view threshold | 8,657.00 (-0.07%) | 8,694.49 (99.57%) | 📈 view plot 🚷 view threshold | 46.00 (+14.51%) | 53.79 (85.52%) | 📈 view plot 🚷 view threshold | 209.00 (-0.03%) | 217.08 (96.28%) |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot 🚨 view alert 🚷 view threshold | 35,750.00 (+0.55%) | 35,745.38 (100.01%) | 📈 view plot 🚷 view threshold | 14,888.00 (+0.28%) | 14,905.42 (99.88%) | 📈 view plot 🚷 view threshold | 21,875.00 (+0.31%) | 21,915.93 (99.81%) | 📈 view plot 🚷 view threshold | 101.00 (+8.32%) | 115.27 (87.62%) | 📈 view plot 🚷 view threshold | 382.00 (+0.69%) | 384.83 (99.27%) |
|
| Branch | std_logic |
| Testbed | sv2 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot 🚷 view threshold | 45.32 (+1.03%) | 48.39 (93.65%) |
| client_sv2_handle_message_mining | 📈 view plot 🚷 view threshold | 73.06 (-2.92%) | 94.20 (77.56%) |
| client_sv2_mining_message_submit_standard | 📈 view plot 🚷 view threshold | 14.69 (+0.17%) | 14.92 (98.47%) |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot 🚷 view threshold | 277.13 (+2.14%) | 306.74 (90.35%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot 🚷 view threshold | 615.65 (+4.42%) | 761.21 (80.88%) |
| client_sv2_open_channel | 📈 view plot 🚷 view threshold | 147.85 (+0.20%) | 159.79 (92.53%) |
| client_sv2_open_channel_serialize | 📈 view plot 🚷 view threshold | 286.69 (+0.61%) | 316.58 (90.56%) |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot 🚷 view threshold | 381.73 (+0.43%) | 453.73 (84.13%) |
| client_sv2_setup_connection | 📈 view plot 🚷 view threshold | 169.23 (+3.83%) | 206.14 (82.10%) |
| client_sv2_setup_connection_serialize | 📈 view plot 🚷 view threshold | 498.27 (+4.22%) | 690.86 (72.12%) |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot 🚷 view threshold | 983.18 (+1.55%) | 1,130.93 (86.94%) |
|
| Branch | std_logic |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result estimated cycles (Result Δ%) | Upper Boundary estimated cycles (Limit %) | Instructions | Benchmark Result instructions (Result Δ%) | Upper Boundary instructions (Limit %) | L1 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot 🚷 view threshold | 8,391.00 (-0.79%) | 8,829.56 (95.03%) | 📈 view plot 🚷 view threshold | 3,689.00 (-1.61%) | 3,889.36 (94.85%) | 📈 view plot 🚷 view threshold | 5,156.00 (-1.95%) | 5,454.73 (94.52%) | 📈 view plot 🚷 view threshold | 10.00 (+41.44%) | 12.11 (82.58%) | 📈 view plot 🚷 view threshold | 91.00 (+0.67%) | 96.16 (94.63%) |
| get_submit | 📈 view plot 🚷 view threshold | 95,453.00 (+0.01%) | 96,157.88 (99.27%) | 📈 view plot 🚷 view threshold | 59,346.00 (-0.21%) | 59,812.89 (99.22%) | 📈 view plot 🚷 view threshold | 85,218.00 (-0.24%) | 85,908.71 (99.20%) | 📈 view plot 🚷 view threshold | 45.00 (-1.56%) | 66.47 (67.70%) | 📈 view plot 🚷 view threshold | 286.00 (+2.20%) | 289.24 (98.88%) |
| get_subscribe | 📈 view plot 🚷 view threshold | 7,872.00 (-1.83%) | 8,380.90 (93.93%) | 📈 view plot 🚷 view threshold | 2,765.00 (-2.50%) | 2,968.42 (93.15%) | 📈 view plot 🚷 view threshold | 3,847.00 (-2.97%) | 4,146.32 (92.78%) | 📈 view plot 🚷 view threshold | 14.00 (+15.84%) | 21.11 (66.33%) | 📈 view plot 🚷 view threshold | 113.00 (-0.96%) | 120.13 (94.06%) |
| serialize_authorize | 📈 view plot 🚷 view threshold | 12,214.00 (-0.48%) | 12,650.73 (96.55%) | 📈 view plot 🚷 view threshold | 5,266.00 (-1.02%) | 5,459.84 (96.45%) | 📈 view plot 🚷 view threshold | 7,324.00 (-1.30%) | 7,617.00 (96.15%) | 📈 view plot 🚷 view threshold | 12.00 (+34.27%) | 15.01 (79.96%) | 📈 view plot 🚷 view threshold | 138.00 (+0.46%) | 143.65 (96.07%) |
| serialize_deserialize_authorize | 📈 view plot 🚷 view threshold | 24,344.00 (-1.37%) | 25,282.15 (96.29%) | 📈 view plot 🚷 view threshold | 9,838.00 (-0.55%) | 10,054.01 (97.85%) | 📈 view plot 🚷 view threshold | 13,889.00 (-0.55%) | 14,207.29 (97.76%) | 📈 view plot 🚷 view threshold | 33.00 (-5.19%) | 44.23 (74.61%) | 📈 view plot 🚷 view threshold | 294.00 (-2.39%) | 316.01 (93.04%) |
| serialize_deserialize_handle_authorize | 📈 view plot 🚷 view threshold | 30,050.00 (-0.88%) | 30,797.60 (97.57%) | 📈 view plot 🚷 view threshold | 12,015.00 (-0.57%) | 12,223.82 (98.29%) | 📈 view plot 🚷 view threshold | 17,000.00 (-0.66%) | 17,313.54 (98.19%) | 📈 view plot 🚷 view threshold | 62.00 (+11.38%) | 68.08 (91.06%) | 📈 view plot 🚷 view threshold | 364.00 (-1.43%) | 382.28 (95.22%) |
| serialize_deserialize_handle_submit | 📈 view plot 🚷 view threshold | 126,471.00 (-0.00%) | 127,200.14 (99.43%) | 📈 view plot 🚷 view threshold | 73,200.00 (-0.12%) | 73,698.62 (99.32%) | 📈 view plot 🚷 view threshold | 104,911.00 (-0.15%) | 105,666.98 (99.28%) | 📈 view plot 🚷 view threshold | 105.00 (-2.65%) | 136.09 (77.15%) | 📈 view plot 🚷 view threshold | 601.00 (+0.83%) | 605.31 (99.29%) |
| serialize_deserialize_handle_subscribe | 📈 view plot 🚷 view threshold | 27,468.00 (-1.27%) | 28,655.43 (95.86%) | 📈 view plot 🚷 view threshold | 9,584.00 (-0.67%) | 9,788.18 (97.91%) | 📈 view plot 🚷 view threshold | 13,543.00 (-0.77%) | 13,846.13 (97.81%) | 📈 view plot 🚷 view threshold | 69.00 (+8.85%) | 75.82 (91.00%) | 📈 view plot 🚷 view threshold | 388.00 (-2.00%) | 417.55 (92.92%) |
| serialize_deserialize_submit | 📈 view plot 🚷 view threshold | 115,163.00 (-0.07%) | 115,995.57 (99.28%) | 📈 view plot 🚷 view threshold | 68,060.00 (-0.07%) | 68,514.35 (99.34%) | 📈 view plot 🚷 view threshold | 97,653.00 (-0.09%) | 98,356.91 (99.28%) | 📈 view plot 🚷 view threshold | 65.00 (+3.12%) | 79.22 (82.05%) | 📈 view plot 🚷 view threshold | 491.00 (+0.01%) | 499.71 (98.26%) |
| serialize_deserialize_subscribe | 📈 view plot 🚷 view threshold | 22,850.00 (-1.68%) | 24,082.36 (94.88%) | 📈 view plot 🚷 view threshold | 8,143.00 (-0.74%) | 8,345.06 (97.58%) | 📈 view plot 🚷 view threshold | 11,465.00 (-0.79%) | 11,754.61 (97.54%) | 📈 view plot 🚷 view threshold | 37.00 (-1.00%) | 44.66 (82.85%) | 📈 view plot 🚷 view threshold | 320.00 (-2.59%) | 349.51 (91.56%) |
| serialize_submit | 📈 view plot 🚷 view threshold | 99,854.00 (-0.01%) | 100,524.90 (99.33%) | 📈 view plot 🚷 view threshold | 61,408.00 (-0.18%) | 61,859.80 (99.27%) | 📈 view plot 🚷 view threshold | 88,074.00 (-0.22%) | 88,758.33 (99.23%) | 📈 view plot 🚷 view threshold | 53.00 (+12.04%) | 66.42 (79.79%) | 📈 view plot 🚷 view threshold | 329.00 (+1.39%) | 333.77 (98.57%) |
| serialize_subscribe | 📈 view plot 🚷 view threshold | 11,317.00 (-0.70%) | 11,761.02 (96.22%) | 📈 view plot 🚷 view threshold | 4,118.00 (-1.56%) | 4,314.89 (95.44%) | 📈 view plot 🚷 view threshold | 5,707.00 (-1.97%) | 6,002.67 (95.07%) | 📈 view plot 🚷 view threshold | 16.00 (+24.12%) | 20.81 (76.88%) | 📈 view plot 🚷 view threshold | 158.00 (+0.34%) | 164.12 (96.27%) |
Most of protocol/v2 crates are almost
no_std, as listed here.Having a lib crate that can be
no_stdorstdby the selection of a feature :#![cfg_attr(not(feature = "std"), no_std)]or the current implementation :
#![cfg_attr(feature = "no_std", no_std)]is only usefull if :
stdrelated dependency (for instancestd::vec::Vec)stdso we disable the functionalities usingstdIn some case we can replace the
stddep by itsallocequivalent if exists (alloc::vec::Vec) and we can keep the functionality inno_stdenvironement.Finally, a
stdbinary can use someno_stddependencies, but anno_stdbinary cannot use anystddeps. So making the low level crates allno_stdwill make them copamtible for every kind of binary (app).We should use the
stdfeature only if some functionality requiresstdand not have anyno_stdequivalent.As far as I tried all protocol/v2/ crates (libs) can be 100%
no_stda,d does not need thestd(orno_std) feature to optionally addstddep.This PR is targeting to get rid of
stddep without loosing any functionality or efficiency.Note: I will make 1 commit per crate to explain what and how I am doing it.
Note2: being
no_allocis another level of complexity for deep embedded system, which is not at all this PR concern.