Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE #563

Merged
merged 704 commits into from
Jan 26, 2024
Merged

DO NOT MERGE #563

merged 704 commits into from
Jan 26, 2024

Conversation

Fi3
Copy link
Collaborator

@Fi3 Fi3 commented May 11, 2023

No description provided.

@pavlenex
Copy link
Collaborator

Partially resolves #555

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Attention: 1306 lines in your changes are missing coverage. Please review.

Comparison is base (6914140) 30.45% compared to head (009c417) 37.40%.
Report is 19 commits behind head on main.

❗ Current head 009c417 differs from pull request most recent head cd3ab95. Consider uploading reports for the commit cd3ab95 to get more accurate results

Files Patch % Lines
roles/jd-client/src/upstream_sv2/upstream.rs 54.17% 192 Missing ⚠️
roles/jd-server/src/main.rs 0.00% 121 Missing ⚠️
...d-server/src/lib/job_declarator/message_handler.rs 0.00% 118 Missing ⚠️
roles/jd-client/src/downstream.rs 72.87% 102 Missing ⚠️
protocols/v2/roles-logic-sv2/src/parsers.rs 0.00% 73 Missing ⚠️
roles/jd-client/src/error.rs 15.47% 71 Missing ⚠️
roles/jd-server/src/lib/template_receiver/mod.rs 0.00% 69 Missing ⚠️
roles/jd-client/src/job_declarator/mod.rs 72.60% 63 Missing ⚠️
roles/jd-server/src/status.rs 0.00% 57 Missing ⚠️
...es/jd-client/src/job_declarator/message_handler.rs 31.57% 52 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
+ Coverage   30.45%   37.40%   +6.94%     
==========================================
  Files         124      152      +28     
  Lines       11999    14556    +2557     
==========================================
+ Hits         3654     5444    +1790     
- Misses       8345     9112     +767     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

🐰Bencher

ReportMon, September 11, 2023 at 10:04:51 UTC
Projectstratum
Branchmain
Testbedsv2
BenchmarkEstimated CyclesInstructionsL1 AccessesL2 AccessesRAM Accesses
client_sv2_handle_message_common🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)✅ (view plot)🚨 (view plot | view alert)
client_sv2_handle_message_mining✅ (view plot)✅ (view plot)✅ (view plot)✅ (view plot)✅ (view plot)
client_sv2_mining_message_submit_standard🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)✅ (view plot)🚨 (view plot | view alert)
client_sv2_mining_message_submit_standard_serialize🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)✅ (view plot)🚨 (view plot | view alert)
client_sv2_mining_message_submit_standard_serialize_deserialize🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)✅ (view plot)🚨 (view plot | view alert)
client_sv2_open_channel🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)✅ (view plot)🚨 (view plot | view alert)
client_sv2_open_channel_serialize🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)✅ (view plot)🚨 (view plot | view alert)
client_sv2_open_channel_serialize_deserialize🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)✅ (view plot)🚨 (view plot | view alert)
client_sv2_setup_connection🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)✅ (view plot)🚨 (view plot | view alert)
client_sv2_setup_connection_serialize🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)✅ (view plot)🚨 (view plot | view alert)
client_sv2_setup_connection_serialize_deserialize🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)✅ (view plot)🚨 (view plot | view alert)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions
Copy link
Contributor

🐰Bencher

ReportMon, September 11, 2023 at 10:04:48 UTC
Projectstratum
Branchmain
Testbedsv1
BenchmarkEstimated CyclesInstructionsL1 AccessesL2 AccessesRAM Accesses
get_authorize🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)
get_submit🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)
get_subscribe🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)✅ (view plot)🚨 (view plot | view alert)
serialize_authorize🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)✅ (view plot)🚨 (view plot | view alert)
serialize_deserialize_authorize🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)✅ (view plot)🚨 (view plot | view alert)
serialize_deserialize_handle_authorize🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)
serialize_deserialize_handle_submit✅ (view plot)✅ (view plot)✅ (view plot)✅ (view plot)✅ (view plot)
serialize_deserialize_handle_subscribe🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)
serialize_deserialize_submit✅ (view plot)✅ (view plot)✅ (view plot)✅ (view plot)✅ (view plot)
serialize_deserialize_subscribe🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)✅ (view plot)🚨 (view plot | view alert)
serialize_submit🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)✅ (view plot)🚨 (view plot | view alert)
serialize_subscribe🚨 (view plot | view alert)🚨 (view plot | view alert)🚨 (view plot | view alert)✅ (view plot)🚨 (view plot | view alert)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

It do not play well with the last MG patch and no one use them.
MG now use tracing so if we someone need log file we can just add a
layer to the tracing subscriber that save logs on a file very easy.
@Fi3 Fi3 merged commit d53bdb7 into main Jan 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants