Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framing crate refactor: cleanup header.rs and remove Frame trait #976

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Framing crate refactor: cleanup header.rs and remove Frame trait #976

merged 2 commits into from
Jul 3, 2024

Commits on Jul 3, 2024

  1. Refactor header.rs 

    1. Removed `NoiseHeader` struct in favor of three constants defined at
the top of the file.
2. Added documentation and changed visibility to `pub(crate)` where
needed.
3. Removed `Header::Default` and `Sv2Frame::Default` impls as they are
unused.
4. Removed `unwrap()`s
    @jbesraa
    jbesraa committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f801433 View commit details
    Browse the repository at this point in the history

  2. Remove Frame trait 

    The `Frame` trait is used solely by a single struct and it is only
adding biolerplate to the code without benifits. We could consider
re-adding it in the future if needed.
    @jbesraa
    jbesraa committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    c62fa3d View commit details
    Browse the repository at this point in the history