Add MSRV 1.75 workflow check #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Report | Tue, July 9, 2024 at 08:21:20 UTC |
| Project | Stratum v2 (SRI) |
| Branch | 981/merge |
| Testbed | sv1 |
🚨 1 ALERT: Threshold Boundary Limit exceeded!
| Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
|---|---|---|---|---|---|
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 784.45 (+4.87%) | 779.87 (100.59%) |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| client-submit-serialize | ✅ (view plot) | 6,602.20 (-4.76%) | 7,340.40 (89.94%) |
| client-submit-serialize-deserialize | ✅ (view plot) | 7,530.90 (-4.08%) | 8,324.87 (90.46%) |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | ✅ (view plot) | 8,213.70 (-2.47%) | 8,830.52 (93.01%) |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | ✅ (view plot) | 899.01 (+0.05%) | 926.69 (97.01%) |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | ✅ (view plot) | 697.19 (+0.03%) | 717.90 (97.12%) |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | ✅ (view plot) | 249.74 (+0.63%) | 255.26 (97.84%) |
| client-sv1-get-authorize/client-sv1-get-authorize | ✅ (view plot) | 158.12 (+0.59%) | 162.49 (97.31%) |
| client-sv1-get-submit | ✅ (view plot) | 6,436.30 (-3.90%) | 7,132.03 (90.25%) |
| client-sv1-get-subscribe/client-sv1-get-subscribe | ✅ (view plot) | 282.70 (+1.43%) | 291.45 (97.00%) |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | 🚨 (view plot | view alert) | 784.45 (+4.87%) | 779.87 (100.59%) |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | ✅ (view plot) | 610.50 (-0.61%) | 637.59 (95.75%) |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | ✅ (view plot) | 206.60 (-0.06%) | 220.03 (93.90%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
| Report | Tue, July 9, 2024 at 08:21:20 UTC |
| Project | Stratum v2 (SRI) |
| Branch | 2024-06-19-msrv |
| Testbed | sv2 |
🚨 10 ALERTS: Threshold Boundary Limits exceeded!
| Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
|---|---|---|---|---|---|
| client_sv2_mining_message_submit_standard | L2 Accesses (accesses) | 🚨 (view plot | view alert) | 26.00 (+47.32%) | 23.31 (111.55%) | |
| client_sv2_mining_message_submit_standard_serialize | L2 Accesses (accesses) | 🚨 (view plot | view alert) | 55.00 (+15.97%) | 52.78 (104.21%) | |
| client_sv2_mining_message_submit_standard_serialize_deserialize | Instructions (instructions) | 🚨 (view plot | view alert) | 10,585.00 (+0.40%) | 10,567.30 (100.17%) | |
| client_sv2_mining_message_submit_standard_serialize_deserialize | L1 Accesses (accesses) | 🚨 (view plot | view alert) | 15,400.00 (+0.38%) | 15,373.90 (100.17%) | |
| client_sv2_open_channel_serialize_deserialize | Instructions (instructions) | 🚨 (view plot | view alert) | 8,027.00 (+0.53%) | 8,009.69 (100.22%) | |
| client_sv2_open_channel_serialize_deserialize | L1 Accesses (accesses) | 🚨 (view plot | view alert) | 11,672.00 (+0.49%) | 11,648.55 (100.20%) | |
| client_sv2_open_channel_serialize_deserialize | L2 Accesses (accesses) | 🚨 (view plot | view alert) | 84.00 (+14.29%) | 82.57 (101.73%) | |
| client_sv2_setup_connection | L2 Accesses (accesses) | 🚨 (view plot | view alert) | 15.00 (+63.31%) | 13.96 (107.42%) | |
| client_sv2_setup_connection_serialize_deserialize | Instructions (instructions) | 🚨 (view plot | view alert) | 14,855.00 (+0.29%) | 14,837.01 (100.12%) | |
| client_sv2_setup_connection_serialize_deserialize | L1 Accesses (accesses) | 🚨 (view plot | view alert) | 21,811.00 (+0.27%) | 21,785.36 (100.12%) |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Estimated Cycles Upper Boundary estimated cycles | (%) | Instructions | Instructions Results instructions | (Δ%) | Instructions Upper Boundary instructions | (%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L1 Accesses Upper Boundary accesses | (%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | L2 Accesses Upper Boundary accesses | (%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) | RAM Accesses Upper Boundary accesses | (%) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | ✅ (view plot) | 2,077.00 (+1.32%) | 2,127.28 (97.64%) | ✅ (view plot) | 473.00 (+0.49%) | 486.40 (97.25%) | ✅ (view plot) | 732.00 (-0.02%) | 755.23 (96.92%) | ✅ (view plot) | 10.00 (+42.86%) | 10.89 (91.86%) | ✅ (view plot) | 37.00 (+0.96%) | 38.56 (95.97%) |
| client_sv2_handle_message_mining | ✅ (view plot) | 8,219.00 (+0.27%) | 8,336.65 (98.59%) | ✅ (view plot) | 2,137.00 (+0.46%) | 2,171.37 (98.42%) | ✅ (view plot) | 3,159.00 (+0.46%) | 3,216.13 (98.22%) | ✅ (view plot) | 39.00 (+1.20%) | 43.61 (89.43%) | ✅ (view plot) | 139.00 (+0.11%) | 141.98 (97.90%) |
| client_sv2_mining_message_submit_standard | ✅ (view plot) | 6,282.00 (+0.10%) | 6,388.45 (98.33%) | ✅ (view plot) | 1,750.00 (+0.03%) | 1,763.19 (99.25%) | ✅ (view plot) | 2,547.00 (-0.26%) | 2,575.91 (98.88%) | 🚨 (view plot | view alert) | 26.00 (+47.32%) | 23.31 (111.55%) | ✅ (view plot) | 103.00 (-0.78%) | 106.90 (96.35%) |
| client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 14,657.00 (-0.79%) | 15,034.13 (97.49%) | ✅ (view plot) | 4,694.00 (+0.01%) | 4,707.19 (99.72%) | ✅ (view plot) | 6,752.00 (-0.04%) | 6,775.27 (99.66%) | 🚨 (view plot | view alert) | 55.00 (+15.97%) | 52.78 (104.21%) | ✅ (view plot) | 218.00 (-1.95%) | 230.00 (94.78%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 27,465.00 (-0.04%) | 27,844.01 (98.64%) | 🚨 (view plot | view alert) | 10,585.00 (+0.40%) | 10,567.30 (100.17%) | 🚨 (view plot | view alert) | 15,400.00 (+0.38%) | 15,373.90 (100.17%) | ✅ (view plot) | 89.00 (+6.19%) | 89.63 (99.30%) | ✅ (view plot) | 332.00 (-0.83%) | 345.30 (96.15%) |
| client_sv2_open_channel | ✅ (view plot) | 4,417.00 (-1.64%) | 4,611.35 (95.79%) | ✅ (view plot) | 1,461.00 (+0.06%) | 1,474.45 (99.09%) | ✅ (view plot) | 2,157.00 (+0.20%) | 2,173.04 (99.26%) | ✅ (view plot) | 11.00 (-8.05%) | 15.23 (72.23%) | ✅ (view plot) | 63.00 (-3.21%) | 68.19 (92.39%) |
| client_sv2_open_channel_serialize | ✅ (view plot) | 14,006.00 (-1.46%) | 14,464.68 (96.83%) | ✅ (view plot) | 5,064.00 (+0.02%) | 5,077.45 (99.74%) | ✅ (view plot) | 7,321.00 (+0.04%) | 7,339.34 (99.75%) | ✅ (view plot) | 42.00 (+12.44%) | 42.27 (99.37%) | ✅ (view plot) | 185.00 (-3.49%) | 199.03 (92.95%) |
| client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 22,557.00 (-0.36%) | 23,023.70 (97.97%) | 🚨 (view plot | view alert) | 8,027.00 (+0.53%) | 8,009.69 (100.22%) | 🚨 (view plot | view alert) | 11,672.00 (+0.49%) | 11,648.55 (100.20%) | 🚨 (view plot | view alert) | 84.00 (+14.29%) | 82.57 (101.73%) | ✅ (view plot) | 299.00 (-1.79%) | 315.02 (94.91%) |
| client_sv2_setup_connection | ✅ (view plot) | 4,659.00 (-0.82%) | 4,765.03 (97.77%) | ✅ (view plot) | 1,502.00 (+0.05%) | 1,515.45 (99.11%) | ✅ (view plot) | 2,274.00 (-0.12%) | 2,299.70 (98.88%) | 🚨 (view plot | view alert) | 15.00 (+63.31%) | 13.96 (107.42%) | ✅ (view plot) | 66.00 (-2.73%) | 69.68 (94.72%) |
| client_sv2_setup_connection_serialize | ✅ (view plot) | 15,942.00 (-1.95%) | 16,503.87 (96.60%) | ✅ (view plot) | 5,963.00 (+0.01%) | 5,976.45 (99.77%) | ✅ (view plot) | 8,662.00 (+0.08%) | 8,677.81 (99.82%) | ✅ (view plot) | 49.00 (+9.61%) | 49.21 (99.57%) | ✅ (view plot) | 201.00 (-4.68%) | 217.96 (92.22%) |
| client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 35,416.00 (-0.33%) | 35,747.98 (99.07%) | 🚨 (view plot | view alert) | 14,855.00 (+0.29%) | 14,837.01 (100.12%) | 🚨 (view plot | view alert) | 21,811.00 (+0.27%) | 21,785.36 (100.12%) | ✅ (view plot) | 110.00 (+10.20%) | 113.21 (97.16%) | ✅ (view plot) | 373.00 (-1.70%) | 384.82 (96.93%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
| Report | Tue, July 9, 2024 at 08:21:21 UTC |
| Project | Stratum v2 (SRI) |
| Branch | 2024-06-19-msrv |
| Testbed | sv1 |
🚨 2 ALERTS: Threshold Boundary Limits exceeded!
| Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
|---|---|---|---|---|---|
| serialize_deserialize_authorize | RAM Accesses (accesses) | 🚨 (view plot | view alert) | 298.00 (+1.06%) | 297.85 (100.05%) | |
| serialize_deserialize_handle_authorize | RAM Accesses (accesses) | 🚨 (view plot | view alert) | 368.00 (+1.13%) | 367.19 (100.22%) |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Estimated Cycles Upper Boundary estimated cycles | (%) | Instructions | Instructions Results instructions | (Δ%) | Instructions Upper Boundary instructions | (%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L1 Accesses Upper Boundary accesses | (%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | L2 Accesses Upper Boundary accesses | (%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) | RAM Accesses Upper Boundary accesses | (%) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | ✅ (view plot) | 8,504.00 (+0.81%) | 8,725.53 (97.46%) | ✅ (view plot) | 3,746.00 (+0.15%) | 3,855.71 (97.15%) | ✅ (view plot) | 5,249.00 (+0.08%) | 5,402.12 (97.17%) | ✅ (view plot) | 7.00 (-11.90%) | 10.40 (67.31%) | ✅ (view plot) | 92.00 (+2.18%) | 94.03 (97.84%) |
| get_submit | ✅ (view plot) | 95,475.00 (-0.08%) | 96,143.54 (99.30%) | ✅ (view plot) | 59,439.00 (-0.05%) | 59,779.65 (99.43%) | ✅ (view plot) | 85,360.00 (-0.05%) | 85,838.02 (99.44%) | ✅ (view plot) | 49.00 (-11.09%) | 62.58 (78.30%) | ✅ (view plot) | 282.00 (-0.03%) | 287.71 (98.01%) |
| get_subscribe | ✅ (view plot) | 7,957.00 (-0.25%) | 8,271.33 (96.20%) | ✅ (view plot) | 2,841.00 (+0.39%) | 2,940.12 (96.63%) | ✅ (view plot) | 3,972.00 (+0.46%) | 4,099.98 (96.88%) | ✅ (view plot) | 13.00 (-19.66%) | 19.82 (65.60%) | ✅ (view plot) | 112.00 (-0.56%) | 116.95 (95.77%) |
| serialize_authorize | ✅ (view plot) | 12,257.00 (+0.42%) | 12,503.93 (98.03%) | ✅ (view plot) | 5,317.00 (+0.11%) | 5,426.71 (97.98%) | ✅ (view plot) | 7,412.00 (+0.06%) | 7,565.46 (97.97%) | ✅ (view plot) | 10.00 (-7.41%) | 13.38 (74.73%) | ✅ (view plot) | 137.00 (+1.06%) | 140.24 (97.69%) |
| serialize_deserialize_authorize | ✅ (view plot) | 24,554.00 (+0.34%) | 24,709.48 (99.37%) | ✅ (view plot) | 9,898.00 (-0.02%) | 10,026.68 (98.72%) | ✅ (view plot) | 13,959.00 (-0.05%) | 14,151.77 (98.64%) | ✅ (view plot) | 33.00 (-9.79%) | 41.62 (79.29%) | 🚨 (view plot | view alert) | 298.00 (+1.06%) | 297.85 (100.05%) |
| serialize_deserialize_handle_authorize | ✅ (view plot) | 30,297.00 (+0.50%) | 30,345.65 (99.84%) | ✅ (view plot) | 12,101.00 (+0.05%) | 12,210.71 (99.10%) | ✅ (view plot) | 17,117.00 (-0.00%) | 17,280.56 (99.05%) | ✅ (view plot) | 60.00 (+2.04%) | 64.73 (92.69%) | 🚨 (view plot | view alert) | 368.00 (+1.13%) | 367.19 (100.22%) |
| serialize_deserialize_handle_submit | ✅ (view plot) | 126,406.00 (-0.00%) | 127,033.73 (99.51%) | ✅ (view plot) | 73,224.00 (-0.04%) | 73,621.57 (99.46%) | ✅ (view plot) | 104,946.00 (-0.04%) | 105,513.86 (99.46%) | ✅ (view plot) | 120.00 (-0.42%) | 131.31 (91.38%) | ✅ (view plot) | 596.00 (+0.19%) | 599.24 (99.46%) |
| serialize_deserialize_handle_subscribe | ✅ (view plot) | 27,495.00 (+0.14%) | 27,602.80 (99.61%) | ✅ (view plot) | 9,643.00 (+0.12%) | 9,742.12 (98.98%) | ✅ (view plot) | 13,640.00 (+0.13%) | 13,775.93 (99.01%) | ✅ (view plot) | 62.00 (-5.91%) | 73.82 (83.98%) | ✅ (view plot) | 387.00 (+0.31%) | 388.59 (99.59%) |
| serialize_deserialize_submit | ✅ (view plot) | 114,999.00 (-0.07%) | 115,655.20 (99.43%) | ✅ (view plot) | 68,001.00 (-0.08%) | 68,404.14 (99.41%) | ✅ (view plot) | 97,559.00 (-0.09%) | 98,152.61 (99.40%) | ✅ (view plot) | 65.00 (-6.39%) | 75.30 (86.32%) | ✅ (view plot) | 489.00 (+0.18%) | 492.39 (99.31%) |
| serialize_deserialize_subscribe | ✅ (view plot) | 22,888.00 (+0.06%) | 23,112.00 (99.03%) | ✅ (view plot) | 8,195.00 (+0.11%) | 8,297.86 (98.76%) | ✅ (view plot) | 11,543.00 (+0.12%) | 11,683.32 (98.80%) | ✅ (view plot) | 36.00 (-8.63%) | 44.09 (81.65%) | ✅ (view plot) | 319.00 (+0.15%) | 321.50 (99.22%) |
| serialize_submit | ✅ (view plot) | 99,792.00 (-0.10%) | 100,471.79 (99.32%) | ✅ (view plot) | 61,483.00 (-0.05%) | 61,829.06 (99.44%) | ✅ (view plot) | 88,207.00 (-0.05%) | 88,691.57 (99.45%) | ✅ (view plot) | 49.00 (-12.04%) | 62.30 (78.65%) | ✅ (view plot) | 324.00 (-0.21%) | 329.20 (98.42%) |
| serialize_subscribe | ✅ (view plot) | 11,294.00 (-0.29%) | 11,607.24 (97.30%) | ✅ (view plot) | 4,188.00 (+0.27%) | 4,287.12 (97.69%) | ✅ (view plot) | 5,829.00 (+0.29%) | 5,959.20 (97.82%) | ✅ (view plot) | 15.00 (-8.33%) | 18.98 (79.05%) | ✅ (view plot) | 154.00 (-0.78%) | 159.77 (96.39%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
| Report | Tue, July 9, 2024 at 08:21:23 UTC |
| Project | Stratum v2 (SRI) |
| Branch | 2024-06-19-msrv |
| Testbed | sv2 |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| client_sv2_handle_message_common | ✅ (view plot) | 44.70 (+0.32%) | 45.25 (98.80%) |
| client_sv2_handle_message_mining | ✅ (view plot) | 72.86 (+0.03%) | 80.35 (90.67%) |
| client_sv2_mining_message_submit_standard | ✅ (view plot) | 14.65 (-0.02%) | 14.69 (99.71%) |
| client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 262.92 (-0.59%) | 284.22 (92.51%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 585.85 (-1.40%) | 627.78 (93.32%) |
| client_sv2_open_channel | ✅ (view plot) | 167.16 (+0.71%) | 173.49 (96.35%) |
| client_sv2_open_channel_serialize | ✅ (view plot) | 282.61 (-0.18%) | 293.31 (96.35%) |
| client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 377.97 (-0.11%) | 423.92 (89.16%) |
| client_sv2_setup_connection | ✅ (view plot) | 168.87 (+2.82%) | 175.06 (96.46%) |
| client_sv2_setup_connection_serialize | ✅ (view plot) | 440.62 (-6.99%) | 507.33 (86.85%) |
| client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 992.72 (+2.17%) | 1,039.74 (95.48%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
plebhash
reviewed
Jun 19, 2024
| @@ -2,7 +2,6 @@ name = "stratum_v2_protocols" | |||
| version = "1.0.0" | |||
| authors = ["The Stratum v2 Developers"] | |||
| edition = "2021" | |||
| rust-version = "1.75.0" | |||
There was a problem hiding this comment.
I get the point of CI, but why is it desirable to remove it from the different Cargo.toml files?
There was a problem hiding this comment.
It does version pinning locally across the rust toolchain, that can affect some local text editors that are configured for example to use only stable or other version. As the CI will cover any new code that does not pass MSRV, this version pinning becomes redundant and annoying for some :D
There was a problem hiding this comment.
Yes, that has happened to me as well; my code editor continuously updates the Cargo.lock file because of this pinning. It would be nice to remove this pinning.
There was a problem hiding this comment.
Perhaps we keep the removal of the rust-version lines in the Cargo.tomls and keep the removal of the rust-toolchain.toml, but then we clearly document in the README.md or the CONTRIBUTING guide that the MSRV is 1.75.0 and we add a pre-commit hook to the .githooks/pre-push to run this workflow locally before pushing?
There was a problem hiding this comment.
the README.md already mention the MSRV, not sure about the hooks tbh as it seems its not widely used
plebhash
reviewed
Jun 19, 2024
|
@plebhash I dont think we have much to update. If we had any |
plebhash
approved these changes
Jun 21, 2024
|
Thanks @rrybarczyk |
jbesraa
force-pushed
the
2024-06-19-msrv
branch
3 times, most recently
from
c9574e9
to
f616fa2
Compare
rrybarczyk
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Ltgm. Do we want to add a bash script in scipts/ to call this? I can also do this in the #1039 PR I have open if you want to add that but don't want to do it in this PR.
rrybarczyk
force-pushed
the
2024-06-19-msrv
branch
from
f616fa2
to
08adad9
Compare
|
@plebhash I think this is good to go |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #980