Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nproc #204

Merged
merged 5 commits into from
Apr 18, 2024
Merged

fix nproc #204

merged 5 commits into from
Apr 18, 2024

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Apr 5, 2024

close #203

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for startling-capybara-2231ea ready!

Name Link
🔨 Latest commit 1048ebe
🔍 Latest deploy log https://app.netlify.com/sites/startling-capybara-2231ea/deploys/661d5e7123eccf00089a5614
😎 Deploy Preview https://deploy-preview-204--startling-capybara-2231ea.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/getting-started.md Outdated Show resolved Hide resolved
@pavlenex
Copy link
Collaborator

@GitGab19 can you review this one when you get a chance please?

src/getting-started.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@GitGab19 GitGab19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention the binaries for the TP provided by Sjors in our guide?
https://github.com/Sjors/bitcoin/releases/tag/sv2-tp-0.1.2

src/getting-started.md Outdated Show resolved Hide resolved
@plebhash
Copy link
Collaborator Author

plebhash commented Apr 13, 2024

Should we mention the binaries for the TP provided by Sjors in our guide?
https://github.com/Sjors/bitcoin/releases/tag/sv2-tp-0.1.2

could be a good alternative to making people build their own TP, perhaps a new PR going in this direction could replace this one

but I would point them to the release page (as a general step), not one specific release

that would avoid the need for future PRs updating the instructions whenever new releases come out

@GitGab19
Copy link
Collaborator

Should we mention the binaries for the TP provided by Sjors in our guide?
https://github.com/Sjors/bitcoin/releases/tag/sv2-tp-0.1.2

could be a good alternative to making people build their own TP, perhaps a new PR going in this direction could replace this one

but I would point them to the release page (as a general step), not one specific release

that would avoid the need for future PRs updating the instructions whenever new releases come out

Yeah I totally agree on the approach 👍

@pavlenex
Copy link
Collaborator

Agreed it is easier with TP binaries. Do we want to do those TP changes in this PR @plebhash ?

@plebhash
Copy link
Collaborator Author

Agreed it is easier with TP binaries. Do we want to do those TP changes in this PR @plebhash ?

done

@pavlenex pavlenex requested a review from GitGab19 April 16, 2024 20:13
@plebhash
Copy link
Collaborator Author

@pavlenex @GitGab19 are you guys familiar with this CI error?

@pavlenex
Copy link
Collaborator

@plebhash Yes linkcheck, Twitter blocks it so it fails, it's always safe to proceed if linkcheck fails at twitter links.

@pavlenex pavlenex merged commit a57fe93 into stratum-mining:main Apr 18, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix number of processors used to build TP
3 participants