moved past supporters tab to be inline with others #212 #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for startling-capybara-2231ea ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @omerskywalker, tested and it looks good on me except on mobile. Any way we can make that one look better? |
|
Hi @pavlenex - I've reduced the font-size in mobile layout to allow tabs to fit inside of the screen width. I also noticed a discrepancy in capitalization formatting between the tabs, and standardized them to capitalize multi-worded tabs.
I included a small adjustment for increased padding in the config tabs on mobile view - to maximize the available real estate on the page without breaking the layout.
Let me know your thoughts on these. |
pavlenex
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the Past Supporters tab to be inline with other tabs
This will create an issue for the layout on mobile as the row will exceed the viewWidth -- this can be resolved by adding a media query for display widths under 440px, then changing the font-size to the text-links to 0.85rem -- will create a separate issue and PR for this.