Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update relay.md to working example #368

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Update relay.md to working example #368

merged 2 commits into from
Sep 21, 2023

Conversation

sdobbelaere
Copy link
Contributor

Updating the code snippet to a working example and clarify some of the name choices

Description

The code sample seems to be from a different library, or older version. This made setting up relay very cryptic and rather confusing. Sample has been adjusted to reflect a working example.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Broken docs

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Updating the code snippet to a working example and clarify some of the name choices
Copy link
Member

@bellini666 bellini666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! :)

@bellini666 bellini666 enabled auto-merge (squash) September 21, 2023 14:53
@bellini666 bellini666 merged commit 063a90d into strawberry-graphql:main Sep 21, 2023
@sdobbelaere sdobbelaere deleted the patch-1 branch September 21, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants