Added missing unpacking of strawberry.LazyType to optimzer.py

[NT-Timm]

The query optimizer doesn't properly unpack LazyType on PaginatedRespone handling.
This fixes it the same way _get_model_hints_from_connection does it.

Types of Changes

• Core
• [x ] Bugfix
• New feature
• Enhancement/optimization
• Documentation

Checklist

• [ x] My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• [x ] I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• [ x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Summary by Sourcery

Bug Fixes:

• Fix the query optimizer to properly unpack LazyType in PaginatedResponse handling by resolving the type.

[sourcery-ai]

Reviewer's Guide by Sourcery

The PR fixes a bug in the query optimizer where LazyType was not being properly unpacked when handling PaginatedResponse. The implementation adds a check to unpack LazyType using resolve_type() before processing, similar to the existing implementation in _get_model_hints_from_connection.

Class diagram for LazyType unpacking in optimizer.py

classDiagram
    class optimizer {
        +_get_model_hints_from_paginated()
    }
    class LazyType {
        +resolve_type()
    }
    optimizer --> LazyType : uses
    note for optimizer "Added LazyType unpacking using resolve_type() in _get_model_hints_from_paginated"

Loading

File-Level Changes

Change	Details	Files
Added LazyType resolution in paginated response handling	Added type check for LazyType instance Added resolution of LazyType using resolve_type() method	strawberry_django/optimizer.py

Possibly linked issues

• Query optimizer doesn't work with relay connection #337: PR fixes LazyType unpacking, addressing the query optimizer issue with relay connections.
• Bug: "AttributeError 'list' object has no attribute '_result_cache'" when using pagination and optimizer #532: PR fixes LazyType unpacking, related to issue's pagination error in DjangoOptimizerExtension.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @NT-Timm - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please add tests to verify the LazyType unpacking behavior for PaginatedResponse handling to prevent future regressions.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[bellini666]

Ty! :)