-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Enable psycopg v3 tests #685
Draft
kwongtn
wants to merge
15
commits into
strawberry-graphql:main
Choose a base branch
from
kwongtn:enable-psycopg-v3-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Co-authored-by: Thiago Bellini Ribeiro <[email protected]>
Co-authored-by: Thiago Bellini Ribeiro <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Signed-off-by: Kwong Tung Nan <[email protected]>
Reviewer's Guide by SourceryThis PR enables tests for psycopg v3, expands Django and Python version support, and migrates from django-mptt to django-tree-queries. Class diagram showing tree structure migrationclassDiagram
note for TreeNode "Replaces MPTT implementation"
class TreeNode {
+parent: TreeNode
+children: List[TreeNode]
+depth: int
+path: str
}
TreeNode --> TreeNode: parent
note for ArrayField "Now supports both psycopg2 and psycopg3"
class ArrayField {
+base_field
+size: Optional[int]
+default: Any
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #685 +/- ##
=======================================
Coverage 89.17% 89.17%
=======================================
Files 41 41
Lines 3778 3778
=======================================
Hits 3369 3369
Misses 409 409 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kwong Tung Nan <[email protected]>
@kwongtn now you can rebase this 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge the following first:
P.s. Not sure if putting like 50 test scenarios is a good idea though 😅
Also I was thinking -- are we even using postgres in tests? 🤔
Types of Changes
Checklist
Summary by Sourcery
Tests: