Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pydantic v2 support #2972
Pydantic v2 support #2972
Changes from 23 commits
ee45b97
70c9423
a66452b
fe52908
356a5fb
0c45267
37b8c2e
f45d576
dc0b9dd
1171abc
43dcf1d
969112b
107ea3c
612a30c
50d71fb
e5673c1
16c674d
94d4844
a116364
58e2f6f
7696efd
79c41d2
3b3a392
817c325
bfd7ac4
9314609
af3299e
8cd57d9
eec5c8e
f17ee94
5afee6b
db26d26
01182e2
d78d907
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set this back to >1.6.1 and update lock file (am I doing this right?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should have these on our typing module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, not sure if anyone will read this comment, but it is related to this change I believe.
On Python 3.9 I'm noticing some issues here when (indirectly) importing from this module:
On Python 3.10 and 3.11 it works fine.
From reading the import handling here I think it makes sense because it seems that this is what happens for different python versions;
Python 3.8 -> ImportError on UnionType
Python 3.9 -> ImportError on UnionType
Python 3.10 -> (no import error)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mark90 this should be fixed now 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great :) Thanks for notifying me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think quite a few are still supported, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will investigate further in an issue / PR because i think pydantic v2's types are just normal annotated types that should work out of the box