-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect TypingUnionType import check #3023
Fix incorrect TypingUnionType import check #3023
Conversation
- TypingUnionType import error check is set to `< 3.9` but 3.9 fails the import and it should be `< 3.10`
Thanks for adding the Here's a preview of the changelog: TypingUnionType import error check is reraised because TypingGenericAlias is checked at the same time which is checked under 3.9 instead of under 3.10 Fix by separating TypingUnionType and TypingGenericAlias imports in their own try-catch Here's the preview release card for twitter: Here's the tweet text:
|
CodSpeed Performance ReportMerging #3023 will not alter performanceComparing Summary
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3023 +/- ##
==========================================
+ Coverage 96.50% 96.53% +0.03%
==========================================
Files 468 468
Lines 29109 29112 +3
Branches 3582 3581 -1
==========================================
+ Hits 28091 28104 +13
+ Misses 835 827 -8
+ Partials 183 181 -2 |
5aa1804
to
325cd87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think we can add a test for this?
not sure how to test this, will attempt it. |
0f01d3e
to
af6e1e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed the pydantic tests to run on all integrations, so the codepath is being triggered now without needing to write new tests 😊
Co-authored-by: Tjeerd.Verschragen <[email protected]> Co-authored-by: Patrick Arminio <[email protected]>
< 3.9
but 3.9 fails the import and it should be< 3.10
Types of Changes
Issues Fixed or Closed by This PR
Checklist