Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missed pydantic v2 tests with error ConstrainedList removed in v2 #3035

Conversation

tjeerddie
Copy link
Contributor

@tjeerddie tjeerddie commented Aug 14, 2023

  • Mark missed pydantic constrained list tests with need_pydantic_v1 since it is removed in pydantic V2

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tjeerddie tjeerddie marked this pull request as draft August 14, 2023 13:51
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 14, 2023

CodSpeed Performance Report

Merging #3035 will not alter performance

Comparing tjeerddie:fix-pydantic-test-constrained-list (a61b07c) with main (2ecaf8a)

Summary

✅ 12 untouched benchmarks

@tjeerddie tjeerddie force-pushed the fix-pydantic-test-constrained-list branch from d9bbd7b to 8bdb4d7 Compare August 14, 2023 13:59
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #3035 (a61b07c) into main (2ecaf8a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3035   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files         468      468           
  Lines       29176    29184    +8     
  Branches     3589     3589           
=======================================
+ Hits        28168    28176    +8     
  Misses        827      827           
  Partials      181      181           

@tjeerddie tjeerddie force-pushed the fix-pydantic-test-constrained-list branch from 8bdb4d7 to ed6dc22 Compare August 14, 2023 14:30
RELEASE.md Outdated Show resolved Hide resolved
@tjeerddie tjeerddie force-pushed the fix-pydantic-test-constrained-list branch from ed6dc22 to ca80e33 Compare August 14, 2023 14:42
@tjeerddie tjeerddie marked this pull request as ready for review August 14, 2023 14:42
- mark ConstrainedList tests with skipif python version under 3.9 because they break in 3.8
@tjeerddie tjeerddie force-pushed the fix-pydantic-test-constrained-list branch from ca80e33 to a61b07c Compare August 15, 2023 07:18
Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patrick91 patrick91 merged commit 4fe8537 into strawberry-graphql:main Aug 15, 2023
49 checks passed
etripier pushed a commit to Greenbax/strawberry that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants