-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default cache dataloader raise key error on non-existing key #3569
Open
dartt0n
wants to merge
11
commits into
strawberry-graphql:main
Choose a base branch
from
dartt0n:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
724ebe3
Fix default cache dataloader raise key error on non-existing key
dartt0n 7a2a88a
Modify test to test behaviour on non-existing cache key
dartt0n 5fe7f6f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 92a4ff0
Update test to explicitly check no exception was raised
dartt0n eab45a5
Update RELEASE.md
dartt0n 4ac166d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c189236
Modify test to test behaviour on non-existing cache key
dartt0n 5b87885
Address B011 Do not assert False
dartt0n f3b225a
fix: typo in RELEASE.md
dartt0n 708013f
fix: typo in RELEASE.md
dartt0n 6b0a704
test: update `test_clear` and `test_clear_nocache` to test the new ca…
dartt0n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
Release type: patch | ||
|
||
Calling `.clear(key)` on default dataloader with non-existing `key` will not throw `KeyError` anymore. Example: | ||
```python | ||
from strawberry.dataloader import DataLoader | ||
|
||
|
||
async def load_data(keys): | ||
return [str(key) for key in keys] | ||
|
||
|
||
dataloader = DataLoader(load_fn=load_data) | ||
dataloader.clear(42) # does not throw KeyError anymore | ||
``` | ||
|
||
This is a patch release with no breaking changes. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Mention import statement for DataLoader
Consider adding a comment or a line to indicate that
DataLoader
should be imported from the relevant module to avoid confusion.