-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more advice on file upload security #3657
Add more advice on file upload security #3657
Conversation
Reviewer's Guide by SourceryThis pull request adds important security information to the file upload documentation for Strawberry, a GraphQL library. It emphasizes that file upload support is disabled by default and provides guidance on enabling it securely. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DoctorJohn - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
This is just a small addition to the file upload docs, mentioning that file upload support is disabled by default and that enabling it requires some security considerations.
This section will be expanded once I finished implementing Strawberry's built-in CSRF protection.
Types of Changes
Issues Fixed or Closed by This PR
Summary by Sourcery
Update the file upload documentation to include security advice, emphasizing the need for CSRF protection when enabling multipart file uploads.
Documentation: