-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use explicit response code to avoid type error #3666
Use explicit response code to avoid type error #3666
Conversation
Reviewer's Guide by SourceryThis pull request enhances the Flask integration in the Strawberry GraphQL library by improving type safety and removing an unnecessary type ignore comment. The changes focus on the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DoctorJohn - I've reviewed your changes - here's some feedback:
Overall Comments:
- Good job on improving type safety and removing the
type: ignore
comment. Consider bundling this change with other minor improvements in a future release rather than creating a separate patch release, unless there are other unreleased changes that would justify a new version.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Thanks for adding the Here's a preview of the changelog: This release tweaks the Flask integration's Here's the tweet text:
|
42e5d32
to
8ab4627
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3666 +/- ##
==========================================
+ Coverage 96.67% 97.01% +0.34%
==========================================
Files 503 503
Lines 33457 33458 +1
Branches 5602 5618 +16
==========================================
+ Hits 32343 32460 +117
+ Misses 880 792 -88
+ Partials 234 206 -28 |
8ab4627
to
f2bc322
Compare
CodSpeed Performance ReportMerging #3666 will not alter performanceComparing Summary
|
Description
This PR removes an unneeded
type: ignore
I just stumbled upon and couldn't get out of my head.Types of Changes
Summary by Sourcery
Refactor the Flask integration's
render_graphql_ide
method to use explicit response parameters, improving type safety and removing an unnecessarytype: ignore
comment. Document the change in a newRELEASE.md
file.Enhancements:
render_graphql_ide
method in the Flask integration to use an explicit response code and content type, removing the need for atype: ignore
comment.Documentation:
RELEASE.md
file to document the patch release, highlighting the stricter typing in the Flask integration.