Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI with new Ubuntu LTS #3667

Merged
merged 5 commits into from
Oct 12, 2024
Merged

Fix CI with new Ubuntu LTS #3667

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5815372
fix ci
Ckk3 Oct 11, 2024
b834cdf
fix precommit
Ckk3 Oct 11, 2024
ea92ef6
change pip to uv
Ckk3 Oct 12, 2024
f821d0d
fix uv
Ckk3 Oct 12, 2024
5537784
fix pre-commit
Ckk3 Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@ jobs:
sessions: ${{ steps.set-matrix.outputs.sessions }}
steps:
- uses: actions/checkout@v4
- run: pip install poetry nox nox-poetry
- run: python3 -m venv .venv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use uv instead? :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I didn’t change it earlier because I wanted to minimize changes, but I will make this changes on this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

- id: set-matrix
shell: bash
run: |
. .venv/bin/activate
pip install poetry nox nox-poetry
echo sessions=$(
nox --json -t tests -l |
jq 'map(
Expand Down Expand Up @@ -82,7 +84,7 @@ jobs:

benchmarks:
name: 📈 Benchmarks
runs-on: ubuntu-latest
runs-on: ubuntu-22.04 # Using this version because CodSpeed doesn't support Ubuntu 24.04 LTS yet.

steps:
- uses: actions/checkout@v4
Expand All @@ -99,7 +101,7 @@ jobs:
if: steps.setup-python.outputs.cache-hit != 'true'

- name: Run benchmarks
uses: CodSpeedHQ/action@v2
uses: CodSpeedHQ/action@v3
with:
token: ${{ secrets.CODSPEED_TOKEN }}
run: poetry run pytest tests/benchmarks --codspeed
Expand Down
Loading