-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nullable Connection types in relay field decorator #3706
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,122 @@ | ||
from typing import Optional, Union | ||
|
||
import strawberry | ||
from strawberry.permission import BasePermission | ||
from strawberry.relay import Connection, Node, connection | ||
|
||
|
||
@strawberry.type | ||
class User(Node): | ||
name: str = "John" | ||
|
||
@classmethod | ||
def resolve_nodes(cls, *, info, node_ids, required): | ||
return [cls() for _ in node_ids] | ||
|
||
|
||
class TestPermission(BasePermission): | ||
message = "Not allowed" | ||
|
||
def has_permission(self, source, info, **kwargs): | ||
return False | ||
|
||
|
||
def test_nullable_connection_with_optional(): | ||
@strawberry.type | ||
class Query: | ||
@connection | ||
def users(self) -> Optional[Connection[User]]: | ||
return None | ||
|
||
schema = strawberry.Schema(query=Query) | ||
query = """ | ||
query { | ||
users { | ||
edges { | ||
node { | ||
name | ||
} | ||
} | ||
} | ||
} | ||
""" | ||
|
||
result = schema.execute_sync(query) | ||
assert result.data == {"users": None} | ||
assert not result.errors | ||
|
||
|
||
def test_nullable_connection_with_union(): | ||
@strawberry.type | ||
class Query: | ||
@connection | ||
def users(self) -> Union[Connection[User], None]: | ||
return None | ||
|
||
schema = strawberry.Schema(query=Query) | ||
query = """ | ||
query { | ||
users { | ||
edges { | ||
node { | ||
name | ||
} | ||
} | ||
} | ||
} | ||
""" | ||
|
||
result = schema.execute_sync(query) | ||
assert result.data == {"users": None} | ||
assert not result.errors | ||
|
||
|
||
def test_nullable_connection_with_permission(): | ||
@strawberry.type | ||
class Query: | ||
@strawberry.permission_classes([TestPermission]) | ||
@connection | ||
def users(self) -> Optional[Connection[User]]: | ||
return Connection[User](edges=[], page_info=None) | ||
|
||
schema = strawberry.Schema(query=Query) | ||
query = """ | ||
query { | ||
users { | ||
edges { | ||
node { | ||
name | ||
} | ||
} | ||
} | ||
} | ||
""" | ||
|
||
result = schema.execute_sync(query) | ||
assert result.data == {"users": None} | ||
assert not result.errors | ||
|
||
|
||
def test_non_nullable_connection(): | ||
@strawberry.type | ||
class Query: | ||
@connection | ||
def users(self) -> Connection[User]: | ||
return Connection[User](edges=[], page_info=None) | ||
|
||
schema = strawberry.Schema(query=Query) | ||
query = """ | ||
query { | ||
users { | ||
edges { | ||
node { | ||
name | ||
} | ||
} | ||
} | ||
} | ||
""" | ||
|
||
result = schema.execute_sync(query) | ||
assert result.data == {"users": {"edges": []}} | ||
assert not result.errors |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UnionType
should be imported fromtypes
, but it is only available on python 3.10+see
is_union
instrawberry/utils/typing.py