Dual output recording #4794
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| @import '../../../styles/index.less'; | ||
| @import './GoLive.m.less'; | ||
|
|
||
| .stream-options { | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-self: flex-end; | ||
| width: 100%; | ||
| } | ||
|
|
||
| .settings-row { | ||
| width: 100%; | ||
| margin: 0px !important; | ||
| padding: 15px; | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| align-self: flex-end; | ||
|
|
||
| :global(.ant-col) { | ||
| padding: 0px; | ||
| } | ||
| } | ||
|
|
||
| .switcher-label { | ||
| flex-grow: 1; | ||
| } | ||
|
|
||
| .recording-switcher { | ||
| justify-self: flex-end; | ||
| color: var(--background); | ||
|
|
||
| :global(.ant-form-item-label) { | ||
| display: none; | ||
| } | ||
|
There was a problem hiding this comment. not worth requiring a change here but just a lil useful thing-- we have a boolean property |
||
|
|
||
| :global(.ant-form-item-control-input) { | ||
| min-height: unset; | ||
| } | ||
|
|
||
| :global(.ant-switch-small) { | ||
| min-width: 36px; | ||
| height: 21px; | ||
| line-height: 21px; | ||
| } | ||
|
|
||
| :global(.ant-switch-small .ant-switch-handle) { | ||
| width: 15px; | ||
| height: 15px; | ||
| top: 3px; | ||
| left: 3px; | ||
| } | ||
|
|
||
| :global(.ant-switch-small.ant-switch-checked .ant-switch-handle) { | ||
| left: calc(100% - 15px - 3px) !important; | ||
| } | ||
|
|
||
| :global(.ant-switch-inner i) { | ||
| color: var(--background); | ||
| display: flex; | ||
| align-self: center; | ||
| padding-right: 2px; | ||
| } | ||
|
|
||
| &:global(.ant-row.ant-form-item) { | ||
| margin-bottom: 0px !important; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| import React from 'react'; | ||
| import styles from './StreamOptions.m.less'; | ||
| import { Services } from 'components-react/service-provider'; | ||
| import { $t } from 'services/i18n'; | ||
| import { Row, Select } from 'antd'; | ||
| import { SwitchInput } from 'components-react/shared/inputs'; | ||
| import { useVuex } from 'components-react/hooks'; | ||
| import { ERecordingQuality } from 'obs-studio-node'; | ||
|
|
||
| /** | ||
| * Renders options for the stream | ||
| * - Vertical Recording Settings | ||
| **/ | ||
| export default function StreamOptions() { | ||
| const { DualOutputService } = Services; | ||
|
|
||
| const { Option } = Select; | ||
|
|
||
| const recordingQualities = [ | ||
|
There was a problem hiding this comment. I believe these should be translated. |
||
| { | ||
| quality: ERecordingQuality.HighQuality, | ||
| name: $t('High, Medium File Size'), | ||
| }, | ||
| { | ||
| quality: ERecordingQuality.HigherQuality, | ||
| name: $t('Indistinguishable, Large File Size'), | ||
| }, | ||
| { | ||
| quality: ERecordingQuality.Lossless, | ||
| name: $t('Lossless, Tremendously Large File Size'), | ||
| }, | ||
| ]; | ||
|
|
||
| const v = useVuex(() => ({ | ||
| recordVertical: DualOutputService.views.recordVertical, | ||
| setRecordVertical: DualOutputService.actions.return.setRecordVertical, | ||
| recordingQuality: DualOutputService.views.recordingQuality, | ||
| setRecordingQuality: DualOutputService.actions.setDualOutputRecordingQuality, | ||
| })); | ||
|
|
||
| return ( | ||
| <div className={styles.streamOptions}> | ||
| <Row | ||
| gutter={16} | ||
| className={styles.settingsRow} | ||
| style={{ | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| alignItems: 'flex-start', | ||
| paddingBottom: '0px', | ||
| }} | ||
| > | ||
| <div className={styles.switcherLabel} style={{ marginBottom: '2px' }}> | ||
| {$t('Recording Quality')} | ||
| </div> | ||
| <Select | ||
| data-name="recording-quality" | ||
| defaultValue={v.recordingQuality.dualOutput} | ||
| style={{ flex: 1, width: '100%' }} | ||
| onChange={option => v.setRecordingQuality('dual', option)} | ||
| value={v.recordingQuality.dualOutput} | ||
| > | ||
| {recordingQualities.map(option => ( | ||
| <Option key={option.quality} value={option.quality}> | ||
| {option.name} | ||
| </Option> | ||
| ))} | ||
| </Select> | ||
| </Row> | ||
| <Row gutter={16} className={styles.settingsRow}> | ||
| <div className={styles.switcherLabel}>{$t('Vertical Recording Only')}</div> | ||
| <SwitchInput | ||
| value={v.recordVertical} | ||
| name="record-vertical" | ||
| onChange={v.setRecordVertical} | ||
| uncontrolled | ||
| className={styles.recordingSwitcher} | ||
| checkedChildren={<i className="icon-check-mark" />} | ||
| /> | ||
| </Row> | ||
| </div> | ||
| ); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Should
RECbe translated?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how it was originally but you bring up a good point. The limitation is that there is only room for three characters on the button. Let's bring it up to the team?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea the character limit is the issue here, as well as i'm not certain other languages have the same shorthand that we do for this term. i think looking into an icon replacement could have value here, as there is a generally accepted icon for recording