STREAM-1597: account for transfer fees when creating Airdrops #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yolley
requested review from
RolginRoman,
LukaStreamflow and
Johnny3223
and removed request for
Johnny3223
| import { SignerWalletAdapter } from "@solana/wallet-adapter-base"; | ||
| import { Connection, Keypair, PublicKey, Transaction, VersionedTransaction } from "@solana/web3.js"; | ||
| import { ContractError } from "@streamflow/common"; | ||
| import { ConfirmationParams, signAndExecuteTransaction, ThrottleParams } from "@streamflow/common/solana"; | ||
|
|
||
| import { fromTxError } from "./generated/errors"; | ||
| import { ONE_IN_BASIS_POINTS } from "./constants"; | ||
|
|
||
| export const divCeilN = (n: bigint, d: bigint): bigint => n / d + (n % d ? BigInt(1) : BigInt(0)); |
There was a problem hiding this comment.
Since it's Friday, BigInt isn't as big as BN.
Also, BN has all of these operations.
I'll merge this and migrate it with staging so Milan can test it during the weekend, but let's fix this with BN asap :)
There was a problem hiding this comment.
BigInt is used in solana js-sdk, that's why we use it here.
| const rawPreFeeAmount = divCeilN(numerator, denominator); | ||
| const fee = rawPreFeeAmount - transferAmount; | ||
| transferAmount = rawPreFeeAmount; | ||
| feeCharged = fee > transferFee.maximumFee ? transferFee.maximumFee : fee; |
There was a problem hiding this comment.
That's the max configured in Transfer Fee Config.
| let feeCharged = BigInt(0); | ||
|
|
||
| if (transferFeeBasisPoints !== BigInt(0)) { | ||
| const numerator = transferAmount * ONE_IN_BASIS_POINTS; |
There was a problem hiding this comment.
Comment around this math would be helpful :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an Airdrop for mint with Transfer Fee extension we need to account for such fees, so that the Escrow has enough funds to distribute.
Logic loosely based on what we have in Rust Solana library https://github.com/solana-labs/solana-program-library/blob/master/token/program-2022/src/extension/transfer_fee/mod.rs#L90
Example transaction https://explorer.solana.com/tx/51qRMSAy8bXW93mGekBZZjQPv7zjja6Eibfab2j2RVKBSVFnn6Fo8qCap1CNPVWybKwQMfj12KpDyayqqwRRP2sU?cluster=devnet