Skip to content

Upgrade MapLibre Compose location to 0.16.0 - #7090

Merged
westnordost merged 5 commits into
streetcomplete:masterfrom
sargunv:sargunv/location-0.16
Sep 11, 2026
Merged

Upgrade MapLibre Compose location to 0.16.0#7090
westnordost merged 5 commits into
streetcomplete:masterfrom
sargunv:sargunv/location-0.16

Conversation

@sargunv

@sargunv sargunv commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Upgrade the standalone MapLibre Compose location module to 0.16.0 and migrate to its location measurement, update event, and heading provider APIs.

Also fixes these existing bugs on master:

  • Survey history could discard a fresh location after a cached one because it compared their ages instead of their measurement times.
  • Exported GPX tracks could have dates in January 1970 because fix ages were interpreted as milliseconds since the Unix epoch but they were actually milliseconds elapsed since the location was measured
  • The compass indicator pointed west when facing east on a north-up map. (Closes Incorrect view rotation angle displayed on map #7079)
  • Granting location permission could leave location updates stopped until the app was backgrounded and reopened.

Validation: Android and iOS simulator compilation pass. The full Android host test suite passes with JDK 21 and TZ=UTC, including the location regression tests. The debug APK builds and launches on a Samsung SM-F966U1 and the location puck was verified manually.

Generated with GPT-6 Astra in Codex.

@sargunv
sargunv force-pushed the sargunv/location-0.16 branch from 59f58ef to f37154f Compare September 10, 2026 06:48
@sargunv
sargunv marked this pull request as ready for review September 10, 2026 07:07
sargunv added a commit to sargunv/StreetComplete that referenced this pull request Sep 10, 2026
@sargunv
Merge PR streetcomplete#7090 location upgrade and consolidate overlap…
76814c9 
…ping changes
@westnordost

westnordost commented Sep 10, 2026

Copy link
Copy Markdown
Member

You beat me to it, thank you!

@westnordost westnordost self-assigned this Sep 10, 2026
westnordost
westnordost requested changes Sep 10, 2026
View reviewed changes
Comment thread app/src/commonMain/kotlin/de/westnordost/streetcomplete/util/ktx/Location.kt
Comment thread app/src/commonTest/kotlin/de/westnordost/streetcomplete/util/ktx/LocationProviderTest.kt Outdated
Comment thread app/src/commonTest/kotlin/de/westnordost/streetcomplete/util/ktx/LocationTest.kt Outdated
Comment thread app/src/commonMain/kotlin/de/westnordost/streetcomplete/CommonModule.kt
@westnordost westnordost removed their assignment Sep 10, 2026
@westnordost westnordost added the iOS necessary for iOS port label Sep 10, 2026
@sargunv sargunv mentioned this pull request Sep 10, 2026
Merged
@westnordost westnordost moved this to In Progress in iOS Port Sep 11, 2026
@sargunv
sargunv requested a review from westnordost September 11, 2026 02:41
sargunv added a commit to sargunv/StreetComplete that referenced this pull request Sep 11, 2026
@sargunv
Merge PR streetcomplete#7090 review fixes and simplify shared map code
9bec9f5
@westnordost
westnordost merged commit 19d1cc3 into streetcomplete:master Sep 11, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Done (unreleased) in iOS Port Sep 11, 2026
@westnordost

westnordost commented Sep 11, 2026

Copy link
Copy Markdown
Member

(Just assigned you to have a nice overview for attribution in the iOS Port (view) board)

@sargunv
sargunv deleted the sargunv/location-0.16 branch September 11, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westnordost westnordost westnordost approved these changes

Assignees

@sargunv sargunv

Labels

ai generated iOS necessary for iOS port

Projects

iOS Port
Status: Done (unreleased)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect view rotation angle displayed on map

2 participants

@sargunv @westnordost