Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Tokyonight themes #101

Merged
merged 3 commits into from
Aug 10, 2024
Merged

Revert Tokyonight themes #101

merged 3 commits into from
Aug 10, 2024

Conversation

echoriiku
Copy link
Collaborator

This reverts commit 0d27fe7.

Copy link

github-actions bot commented Aug 9, 2024

JSON and YAML Validation Results

JSON Validation Results

  • ✅ File(s) Passed: 0
  • ❌ File(s) Failed: 2
  • ⏭️ File(s) Skipped: 0

Violations:

[
  {
    "file": "themes/tokyonight-dark/v1/theme.json",
    "errors": [
      {
        "path": "/scopes/base/primary",
        "message": "must have required property 'accentForeground'"
      }
    ]
  },
  {
    "file": "themes/tokyonight-light/v1/theme.json",
    "errors": [
      {
        "path": "/scopes/base/primary",
        "message": "must have required property 'accentForeground'"
      }
    ]
  }
]

@echoriiku
Copy link
Collaborator Author

It seems like the errors might be due to recent changes in the Notesnook scheme. Since the theme is about a year old, it may not be compatible with the current scheme. A force merge might be necessary to revert those changes.

Copy link

JSON and YAML Validation Results

JSON Validation Results

  • ✅ File(s) Passed: 0
  • ❌ File(s) Failed: 2
  • ⏭️ File(s) Skipped: 0

Violations:

[
  {
    "file": "themes/tokyonight-dark/v1/theme.json",
    "errors": [
      {
        "path": "/scopes/base/primary",
        "message": "must have required property 'accentForeground'"
      }
    ]
  },
  {
    "file": "themes/tokyonight-light/v1/theme.json",
    "errors": [
      {
        "path": "/scopes/base/primary",
        "message": "must have required property 'accentForeground'"
      }
    ]
  }
]

1 similar comment
Copy link

JSON and YAML Validation Results

JSON Validation Results

  • ✅ File(s) Passed: 0
  • ❌ File(s) Failed: 2
  • ⏭️ File(s) Skipped: 0

Violations:

[
  {
    "file": "themes/tokyonight-dark/v1/theme.json",
    "errors": [
      {
        "path": "/scopes/base/primary",
        "message": "must have required property 'accentForeground'"
      }
    ]
  },
  {
    "file": "themes/tokyonight-light/v1/theme.json",
    "errors": [
      {
        "path": "/scopes/base/primary",
        "message": "must have required property 'accentForeground'"
      }
    ]
  }
]

@thecodrr thecodrr merged commit 83c910c into streetwriters:main Aug 10, 2024
1 check failed
@echoriiku echoriiku deleted the revert-tokyonight branch August 14, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants