web: add support for multiline titles #7290
Open
+22
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 01zulfi <[email protected]>
thecodrr
requested changes
Jan 20, 2025
Comment on lines
+169
to
+173
| test("note title should allow newlines", () => | ||
| noteTest({ title: "Hello\nhello", content: TEST_NOTE.content }).then( | ||
| async ({ db, id }) => { | ||
| const note = await db.notes.note(id); | ||
| expect(note?.title).toBe("Hello hello"); | ||
| expect(note?.title).toBe("Hello\nhello"); |
There was a problem hiding this comment.
We don't allow newlines in titles. Why is the test being changed here?
There was a problem hiding this comment.
This PR adds support for multilines which includes newlines as well
|
This PR also isn't resizing the title input when the title exceeds screen width and wraps. |
|
What do you mean? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 01zulfi [email protected]