Skip to content

[Build] Signing: Use managed identities #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[Build] Signing: Use managed identities #2841

wants to merge 1 commit into from

Conversation

xen2
Copy link
Member

@xen2 xen2 commented Jul 16, 2025

PR Details

Rearrange signing system to use managed identities.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@xen2 xen2 force-pushed the managed_identities branch from d88188d to 6dbfa51 Compare July 16, 2025 22:22
@Eideren Eideren mentioned this pull request Jul 22, 2025
Merged
8 tasks
@xen2 xen2 force-pushed the managed_identities branch from 6dbfa51 to cdf4586 Compare July 29, 2025 20:18
@xen2 xen2 force-pushed the managed_identities branch from cdf4586 to 7e815f6 Compare July 29, 2025 20:29
@Doprez Doprez mentioned this pull request Jul 31, 2025
Closed
Ethereal77
Ethereal77 reviewed Aug 1, 2025
View reviewed changes
build/sign/update.bat
dotnet tool install sign --tool-path . --version 0.9.1-beta.25278.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question:
If we can install the sing tool with a specific version every time we need it, then why do we need to include its files in the repo instead if lettting it download when needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Ethereal77 Ethereal77 Ethereal77 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xen2 @Ethereal77