Skip to content
This repository has been archived by the owner on Jul 15, 2021. It is now read-only.

Use Python 3.7 compatible dependencies and flask-session fix #11

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

apakulov-stripe
Copy link

@apakulov-stripe apakulov-stripe commented Feb 5, 2020

Fixing two things for our environment:

  • Python 3.7 compatible dependencies (gevent, greenlet and flask-session)
  • Fixing flask_session import

r? @elewis-stripe

Copy link

@elewis-stripe elewis-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment, the rest seems good to me

@@ -669,6 +669,10 @@ def _pair_key_conflicts_for_services(_id, credential_keys, services):
return conflicts


def _lowercase_credential_pairs(credential_pairs):
return {i.lower(): j for i, j in credential_pairs.items()}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we actually removed this deliberately, unless it's breaking something? The original commit references a specific PR which still hasn't been merged yet:
bf261da
lyft#103

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, my bad, removed in c73a70d

Copy link

@elewis-stripe elewis-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apakulov-stripe apakulov-stripe merged commit a1c74fc into stripe Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants