Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bank payments in native Link #10070

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed          
          ├───────────┬───────────┬──────────┼──────────┬──────────┬──────────
 APK      │ old       │ new       │ diff     │ old      │ new      │ diff     
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
      dex │     4 MiB │     4 MiB │ +2.2 KiB │  8.7 MiB │  8.7 MiB │ +4.2 KiB 
     arsc │   2.3 MiB │   2.3 MiB │      0 B │  2.3 MiB │  2.3 MiB │      0 B 
 manifest │   5.1 KiB │   5.1 KiB │      0 B │ 25.7 KiB │ 25.7 KiB │      0 B 
      res │ 910.3 KiB │ 910.3 KiB │      0 B │  1.4 MiB │  1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │    6 MiB │    6 MiB │      0 B 
    asset │   1.6 MiB │   1.6 MiB │     -1 B │  1.6 MiB │  1.6 MiB │     -1 B 
    other │   1.4 MiB │   1.4 MiB │     -5 B │  1.6 MiB │  1.6 MiB │      0 B 
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
    total │  12.7 MiB │  12.7 MiB │ +2.2 KiB │ 21.7 MiB │ 21.7 MiB │ +4.2 KiB 

 DEX     │ old   │ new   │ diff            
─────────┼───────┼───────┼─────────────────
   files │     1 │     1 │   0             
 strings │ 41201 │ 41212 │ +11 (+24 -13)   
   types │ 14252 │ 14262 │ +10 (+22 -12)   
 classes │ 11903 │ 11911 │  +8 (+11 -3)    
 methods │ 60495 │ 60531 │ +36 (+425 -389) 
  fields │ 40662 │ 40680 │ +18 (+378 -360) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  243 │  243 │  0   
 entries │ 6248 │ 6248 │  0
APK
     compressed      │     uncompressed     │                                           
──────────┬──────────┼───────────┬──────────┤                                           
 size     │ diff     │ size      │ diff     │ path                                      
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
    4 MiB │ +2.2 KiB │   8.7 MiB │ +4.2 KiB │ ∆ classes.dex                             
  7.8 KiB │     -6 B │   7.7 KiB │     -6 B │ ∆ assets/dexopt/baseline.prof             
  1,010 B │     +5 B │     878 B │     +5 B │ ∆ assets/dexopt/baseline.profm            
  1.2 KiB │     -2 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA                       
 50.4 KiB │     -2 B │ 118.9 KiB │      0 B │ ∆ META-INF/MANIFEST.MF                    
    271 B │     -1 B │     120 B │      0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  4.1 MiB │ +2.2 KiB │   8.9 MiB │ +4.2 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   41201 │ 41212 │ +11 (+24 -13) 
  
  + Lc7/c;
  + Lc7/d;
  + Lc7/e;
  + Lc7/f;
  + Lc7/g;
  + Lc7/h;
  + Lc7/i;
  + LinkCardBrandConfirmationOption(paymentDetailsId=
  + Lj7/f;
  + Lr6/E;
  + Lx6/u;
  + Lx6/v;
  + [Lc7/c;
  + [Lc7/f;
  + [Lc7/i;
  + [Lcom/google/android/material/datepicker/d;
  + [Lcom/google/android/material/datepicker/o;
  + [Lh3/e;
  + [Lj7/d;
  + [Ll3/d;
  + [Lt8/h;
  + [Lv5/f;
  + [Lv5/l;
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"7ceeae3","r8-mode":"full","version":"8.7.14"}
  
  - LT6/V;
  - Lcom/google/android/material/datepicker/A;
  - Ll3/f;
  - [Lc7/b;
  - [Lcom/google/android/material/datepicker/e;
  - [Lcom/google/android/material/datepicker/p;
  - [Lh3/c;
  - [Lj7/c;
  - [Ll3/f;
  - [Lt8/f;
  - [Lv5/d;
  - [Lv5/k;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"4f9fe7b","r8-mode":"full","version":"8.7.14"}
  

TYPES:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   14252 │ 14262 │ +10 (+22 -12) 
  
  + Lc7/c;
  + Lc7/d;
  + Lc7/e;
  + Lc7/f;
  + Lc7/g;
  + Lc7/h;
  + Lc7/i;
  + Lj7/f;
  + Lr6/E;
  + Lx6/u;
  + Lx6/v;
  + [Lc7/c;
  + [Lc7/f;
  + [Lc7/i;
  + [Lcom/google/android/material/datepicker/d;
  + [Lcom/google/android/material/datepicker/o;
  + [Lh3/e;
  + [Lj7/d;
  + [Ll3/d;
  + [Lt8/h;
  + [Lv5/f;
  + [Lv5/l;
  
  - LT6/V;
  - Lcom/google/android/material/datepicker/A;
  - Ll3/f;
  - [Lc7/b;
  - [Lcom/google/android/material/datepicker/e;
  - [Lcom/google/android/material/datepicker/p;
  - [Lh3/c;
  - [Lj7/c;
  - [Ll3/f;
  - [Lt8/f;
  - [Lv5/d;
  - [Lv5/k;
  

METHODS:

   old   │ new   │ diff            
  ───────┼───────┼─────────────────
   60495 │ 60531 │ +36 (+425 -389) 
  
  + A5.I0 <init>(d, m, c, h, h, h)
  + A5.I0 <init>(d, h, h, m, h, h)
  + A5.s0 <init>(r, I, L, f)
  + C.D0 <init>(c, PriorityBlockingQueue, h)
  + C6.n <init>(S, M, z, r, c, d)
  + E0.o <init>(h, c, s)
  + E6.d <init>(z, b, r, W0, d, j, c)
  + F6.s <init>(z, c, d, w, c, c, a)
  + G1.m0 <init>(h, View)
  + G1.u0 <init>(h, e, n, l)
  + G6.p <init>(b, r, c, d, boolean, a, a, a)
  + H6.E <init>(z, b, r, W0, d, c, c, c)
  + J5.k <init>(a, e, String, Throwable)
  + P.u B(String, String, String, e)
  + P.u n(String, String, String, e)
  + P.u q(String, String, e, String, String, Integer, String)
  + P.u r(String, String, e, String, String)
  + Q6.w <init>(String, boolean)
  + S5.O <init>(v, X, M, j, w, I, E, d, p, a, f, u0)
  + S5.d <init>(h, h, h, h, h, h, h)
  + S7.e a() → r
  + W6.b <init>(r)
  + W6.b h(f, c) → Object
  + W6.b i(f, c) → Object
  + Y7.E j() → d
  + Y7.E k() → f
  + Z5.a <init>(a, f)
  + Z5.a k() → f
  + Z5.b <init>(a, f)
  + Z5.b k() → f
  + Z5.c <init>(a, f)
  + Z5.c k() → f
  + Z5.d k() → f
  + Z5.o <init>(a, H2, f)
  + a.a p0(Throwable, e) → Throwable
  + c7.a <init>(n)
  + c7.b <init>(Y)
  + c7.c <clinit>()
  + c7.c <init>(Y)
  + c7.c describeContents() → int
  + c7.c equals(Object) → boolean
  + c7.c hashCode() → int
  + c7.c toString() → String
  + c7.c writeToParcel(Parcel, int)
  + c7.d <init>(b, c)
  + c7.d q(Object) → Object
  + c7.e <init>(b, c)
  + c7.e q(Object) → Object
  + c7.f <clinit>()
  + c7.f <init>(String)
  + c7.f describeContents() → int
  + c7.f equals(Object) → boolean
  + c7.f hashCode() → int
  + c7.f toString() → String
  + c7.f writeToParcel(Parcel, int)
  + c7.g <init>(D, E, x)
  + c7.g <init>(T, a, E)
  + c7.g a(m, e, J) → Object
  + c7.g b(Object)
  + c7.g c(c, n) → Object
  + c7.g d(m, e) → boolean
  + c7.g e(m, e, j, Parcelable) → j
  + c7.g f(Object, Object, m, e)
  + c7.g g(m) → m
  + c7.g getKey() → String
  + c7.g h(h, c) → Object
  + c7.g i(h, S, c) → Object
  + c7.g j(h, c) → Object
  + c7.g k(h) → W
  + c7.g l(c)
  + c7.h <init>(int)
  + c7.h createFromParcel(Parcel) → Object
  + c7.h newArray(int) → Object[]
  + c7.i <clinit>()
  + c7.i <init>(z, boolean)
  + c7.i describeContents() → int
  + c7.i equals(Object) → boolean
  + c7.i hashCode() → int
  + c7.i toString() → String
  + c7.i writeToParcel(Parcel, int)
  + com.google.android.gms.wallet.button.ButtonOptions e() → h
  + com.google.android.material.datepicker.MaterialCalendarGridView a() → p
  + com.google.android.material.datepicker.b <init>(o, o, d, o, int)
  + com.google.android.material.datepicker.d <clinit>()
  + com.google.android.material.datepicker.d <init>(long)
  + com.goo
...✂

@tillh-stripe tillh-stripe force-pushed the tillh/native-link-bank-payments branch 5 times, most recently from 4e1f8bc to 6478b1a Compare February 7, 2025 21:51
GIT_VALID_PII_OVERRIDE
@tillh-stripe tillh-stripe force-pushed the tillh/native-link-bank-payments branch from 6478b1a to 1782b5c Compare February 7, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant