Skip to content

Conversation

@jkelle-stripe
Copy link
Contributor

@jkelle-stripe jkelle-stripe commented Nov 26, 2025

Summary

Adds a new analytic event param to add visibility into whether native Link is available or not.

Motivation

Improved visibility and matching stripe/stripe-ios#5863.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │   1.1 MiB │   1.1 MiB │  0 B │   1.1 MiB │   1.1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 303.5 KiB │ 303.5 KiB │  0 B │ 457.7 KiB │ 457.7 KiB │  0 B 
   native │   7.9 MiB │   7.9 MiB │  0 B │  19.3 MiB │  19.3 MiB │  0 B 
    asset │   7.7 KiB │   7.7 KiB │  0 B │   7.5 KiB │   7.5 KiB │  0 B 
    other │  95.6 KiB │  95.6 KiB │ -4 B │ 183.6 KiB │ 183.6 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  11.5 MiB │  11.5 MiB │ -4 B │  25.4 MiB │  25.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20721 │ 20721 │ 0 (+0 -0) 
   types │  6513 │  6513 │ 0 (+0 -0) 
 classes │  5277 │  5277 │ 0 (+0 -0) 
 methods │ 31557 │ 31557 │ 0 (+0 -0) 
  fields │ 18290 │ 18290 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  163 │  163 │  0   
 entries │ 3667 │ 3667 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 29.2 KiB │ -3 B │  64.6 KiB │  0 B │ ∆ META-INF/CERT.SF     
 25.9 KiB │ -2 B │  64.6 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
  1.2 KiB │ +1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
──────────┼──────┼───────────┼──────┼────────────────────────
 56.3 KiB │ -4 B │ 130.4 KiB │  0 B │ (total)

@jkelle-stripe jkelle-stripe marked this pull request as ready for review December 1, 2025 14:27
@jkelle-stripe jkelle-stripe requested review from a team as code owners December 1, 2025 14:27
}

@Test
fun `create returns false for link_native_available when native link is not available`() = runScenario {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these tests all that useful? All they're really testing is the functionality of the fake link gate?

I think having a single test with a true value is probably enough, right?

@jkelle-stripe jkelle-stripe merged commit 5512720 into master Dec 1, 2025
19 checks passed
@jkelle-stripe jkelle-stripe deleted the jkelle/native-link-analytic branch December 1, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants