-
Notifications
You must be signed in to change notification settings - Fork 696
Add link_native_available Analytic
#12061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Diffuse output: APK |
jaynewstrom-stripe
previously approved these changes
Dec 1, 2025
| } | ||
|
|
||
| @Test | ||
| fun `create returns false for link_native_available when native link is not available`() = runScenario { |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these tests all that useful? All they're really testing is the functionality of the fake link gate?
I think having a single test with a true value is probably enough, right?
jaynewstrom-stripe
approved these changes
Dec 1, 2025
tillh-stripe
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new analytic event param to add visibility into whether native Link is available or not.
Motivation
Improved visibility and matching stripe/stripe-ios#5863.
Testing
Screenshots
Changelog