-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[connect] Load Account Onboarding #9689
Conversation
|
||
@OptIn(ExperimentalMaterialApi::class) | ||
@Composable | ||
fun BasicComponentExampleContent( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 Moved to connect-example/src/main/java/com/stripe/android/connect/example/ui/common/BasicComponentExample.kt
import kotlinx.coroutines.launch | ||
|
||
@Composable | ||
fun BasicComponentExample( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 I don't love the naming in this file but we can iterate.
|
||
@OptIn(PrivateBetaConnectSDK::class) | ||
@AndroidEntryPoint | ||
abstract class BasicComponentExampleActivity : FragmentActivity() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 Basically extracted from PayoutsExampleActivity
Diffuse output:
APK
|
c3efb7f
to
53af3a4
Compare
d9fdd0f
to
e43b2dd
Compare
e43b2dd
to
624a5a0
Compare
624a5a0
to
13f9984
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary
Init functional API to load
account-onboarding
component and use it in the example app.The diff is large because I also refactored the example app code to easily add a basic example component activity. It's mostly straightforward extracting into reusable classes/composables.
Motivation
https://jira.corp.stripe.com/browse/MXMOBILE-2506
Testing
Screenshots
Screen.Recording.2024-11-21.at.10.41.43.AM-compressed.mov