Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connect] Load Account Onboarding #9689

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

lng-stripe
Copy link
Contributor

Summary

Init functional API to load account-onboarding component and use it in the example app.

The diff is large because I also refactored the example app code to easily add a basic example component activity. It's mostly straightforward extracting into reusable classes/composables.

Motivation

https://jira.corp.stripe.com/browse/MXMOBILE-2506

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Screen.Recording.2024-11-21.at.10.41.43.AM-compressed.mov


@OptIn(ExperimentalMaterialApi::class)
@Composable
fun BasicComponentExampleContent(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Moved to connect-example/src/main/java/com/stripe/android/connect/example/ui/common/BasicComponentExample.kt

import kotlinx.coroutines.launch

@Composable
fun BasicComponentExample(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 I don't love the naming in this file but we can iterate.


@OptIn(PrivateBetaConnectSDK::class)
@AndroidEntryPoint
abstract class BasicComponentExampleActivity : FragmentActivity() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Basically extracted from PayoutsExampleActivity

@lng-stripe lng-stripe marked this pull request as ready for review November 21, 2024 15:46
@lng-stripe lng-stripe requested a review from a team as a code owner November 21, 2024 15:46
Copy link
Contributor

github-actions bot commented Nov 21, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ +5 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +5 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19966 │ 19966 │ 0 (+0 -0) 
   types │  6188 │  6188 │ 0 (+0 -0) 
 classes │  4979 │  4979 │ 0 (+0 -0) 
 methods │ 29759 │ 29759 │ 0 (+0 -0) 
  fields │ 17526 │ 17526 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 25.3 KiB │ +6 B │  62.8 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
 28.5 KiB │ -1 B │  62.9 KiB │  0 B │ ∆ META-INF/CERT.SF     
──────────┼──────┼───────────┼──────┼────────────────────────
 53.8 KiB │ +5 B │ 125.7 KiB │  0 B │ (total)

@lng-stripe lng-stripe force-pushed the lng/progress-bar-appearance branch from c3efb7f to 53af3a4 Compare November 21, 2024 16:57
@lng-stripe lng-stripe force-pushed the lng/connect-init-onboarding branch from d9fdd0f to e43b2dd Compare November 21, 2024 16:58
Base automatically changed from lng/progress-bar-appearance to master December 2, 2024 18:06
@lng-stripe lng-stripe force-pushed the lng/connect-init-onboarding branch from e43b2dd to 624a5a0 Compare December 2, 2024 18:08
@lng-stripe lng-stripe force-pushed the lng/connect-init-onboarding branch from 624a5a0 to 13f9984 Compare December 2, 2024 21:30
Copy link
Contributor

@simond-stripe simond-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lng-stripe lng-stripe merged commit 738418d into master Dec 3, 2024
13 checks passed
@lng-stripe lng-stripe deleted the lng/connect-init-onboarding branch December 3, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants