Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest version of Newtonsoft.Json #2930

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

ramya-stripe
Copy link
Contributor

@ramya-stripe ramya-stripe commented Jun 24, 2024

Why?
In order to best support our users and to incorporate bug and security fixes, we have to upgrade our 3rd party dependencies from time to time. Json.NET 13.0.3 resolves a vulnerability in the Newtonsoft Json.NET library: GHSA-5crp-9r3c-p9vr. This PR upgrades the Newtonsoft Json.NET library standardizes it across all .NET targets.

See #2800 for the original issue.

What?

  • modified the csproj file to remove per-target Newtonsoft.Json dependencies
  • changed Newtonsoft.Json dependency version to be 13.0.3

Changelog

⚠️ Newtonsoft.Json dependency has been upgraded for all .NET target runtimes. This is potentially a breaking change if you also depend on Newtonsoft.Json directly from your application. To migrate, please upgrade the version of Newtonsoft.Json your application depends on. If you have runtime conflicts with another library dependency, you can use <bindingRedirect> to specify which version .NET should load (see https://stackoverflow.com/a/51053646 and https://learn.microsoft.com/en-us/dotnet/framework/configure-apps/file-schema/runtime/bindingredirect-element)

@jar-stripe jar-stripe merged commit b1e909a into sdk-release/next-major Sep 20, 2024
4 checks passed
@jar-stripe jar-stripe deleted the ramya/newton branch September 20, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants