Skip to content

Conversation

@gbirch-stripe
Copy link
Collaborator

Summary

Motivation

Testing

Changelog

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

🚨 New dead code detected in this PR:

FormSpecProvider.swift:20 warning: Enum case 'failedToLoadSpecs' is unused
PaymentSheetFormFactory+Affirm.swift:7 warning: Imported module 'StripeCore' is unused
PaymentSheetFormFactory+Affirm.swift:8 warning: Imported module 'StripePayments' is unused
PaymentSheetFormFactory+AfterpayClearpay.swift:7 warning: Imported module 'StripeCore' is unused
PaymentSheetFormFactory+AfterpayClearpay.swift:8 warning: Imported module 'StripePayments' is unused
PaymentSheetFormFactory+Multibanco.swift:7 warning: Imported module 'StripeCore' is unused
PaymentSheetFormFactory+Multibanco.swift:8 warning: Imported module 'StripePayments' is unused
PaymentSheetFormFactory+PromptPay.swift:7 warning: Imported module 'StripeCore' is unused
PaymentSheetFormFactory+PromptPay.swift:8 warning: Imported module 'StripePayments' is unused
PaymentSheetFormFactory.swift:23 warning: Enum case 'missingV1FromSelectorSpec' is unused
PaymentSheetFormFactory.swift:803 warning: Function 'makeCountry(countryCodes:apiPath:)' is unused
PaymentSheetFormFactory.swift:988 warning: Function 'makeDefaultsApplierWrapper(for:)' is unused

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

[find-dead-code]

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

⚠️ Public API changes detected:

StripePayments

+ @objc public var bank: Swift.String?
+ @objc public var bank: Swift.String?

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

@gbirch-stripe gbirch-stripe force-pushed the gbirch/remove-form-specs branch 2 times, most recently from bd2581d to 1ffc3c7 Compare December 19, 2025 00:08
@gbirch-stripe gbirch-stripe force-pushed the gbirch/remove-form-specs branch from 1ffc3c7 to f5bcb27 Compare December 19, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants