Move Issuing files to StripeIssuing SDK [Do not merge until Jan 4, 2025] #5934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 Snapshot TestBase build not foundNo build was found for the base commit c3a8ff7. This is required to generate a snapshot diff for your pull request. It's possible that you created a branch off the base commit before all of the CI steps have finished processing, e.g. the one that uploads a build to our system. If that's the case, no problem! Just wait and this will eventually resolve. 🛸 Powered by Emerge Tools |
1 build increased size, 7 builds had no size change, 1 build errored
StripeSize 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| 🗑 Stripe.STPFakeAddPaymentPassViewController | ⬇️ -13.0 kB |
| 🗑 Stripe.STPEphemeralKeyManager | ⬇️ -7.0 kB |
| 🗑 Stripe.STPPinManagementService | ⬇️ -6.4 kB |
| 🗑 Stripe.STPPushProvisioningDetailsParams | ⬇️ -5.5 kB |
| 📝 StripeIssuing.STPFakeAddPaymentPassViewController.viewDidLoad | ⬆️ 5.1 kB |
View Treemap
StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize
No changes to report
StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize
No changes to report
StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize
No changes to report
StripeIdentitySize 1.0 (1)
com.stripe.StripeIdentitySize
No changes to report
StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize
No changes to report
StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize
No changes to report
StripeConnectSize 1.0 (1)
com.stripe.StripeConnectSize
No changes to report
Unsuccessful Builds
| Name | Message |
|---|---|
| StripeIssuingSize com.stripe.StripeIssuingSize |
The diff could not be determined because no build for c3a8ff7 was uploaded |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
Stripe- @objc get
- @objc get
- @objc get
- get
- get
- get
- get
- @_Concurrency.MainActor @preconcurrency @objc convenience override dynamic public init(nibName nibNameOrNil: Swift.String?, bundle nibBundleOrNil: Foundation.Bundle?)
- @_Concurrency.MainActor @preconcurrency @objc override dynamic public func viewDidLoad()
- @_Concurrency.MainActor @preconcurrency @objc required convenience dynamic public init?(coder aDecoder: Foundation.NSCoder)
- @available(*, deprecated, renamed: "requestConfiguration(withName:description:last4:brand:primaryAccountIdentifier:)", message: "Use `requestConfiguration(withName:description:last4:brand:primaryAccountIdentifier:)` instead.")
- @objc @_Concurrency.MainActor @preconcurrency public class func canAddPaymentPass() -> Swift.Bool
- @objc @_Concurrency.MainActor @preconcurrency weak public var delegate: (any PassKit.PKAddPaymentPassViewControllerDelegate)?
- @objc deinit
- @objc deinit
- @objc deinit
- @objc deinit
- @objc public class func requestConfiguration(withName name: Swift.String, description: Swift.String?, last4: Swift.String?, brand: StripePayments.STPCardBrand) -> PassKit.PKAddPaymentPassRequestConfiguration
- @objc public class func requestConfiguration(withName name: Swift.String, description: Swift.String?, last4: Swift.String?, brand: StripePayments.STPCardBrand, primaryAccountIdentifier: Swift.String?) -> PassKit.PKAddPaymentPassRequestConfiguration
- @objc public func addPaymentPassViewController(_ controller: PassKit.PKAddPaymentPassViewController, generateRequestWithCertificateChain certificates: [Foundation.Data], nonce: Foundation.Data, nonceSignature: Foundation.Data, completionHandler handler: @escaping (PassKit.PKAddPaymentPassRequest) -> Swift.Void)
- @objc public func retrievePin(_ cardId: Swift.String, verificationId: Swift.String, oneTimeCode: Swift.String, completion: @escaping StripePayments.STPPinCompletionBlock)
- @objc public func updatePin(_ cardId: Swift.String, newPin: Swift.String, verificationId: Swift.String, oneTimeCode: Swift.String, completion: @escaping StripePayments.STPPinCompletionBlock)
- @objc public init(keyProvider: any Stripe.STPIssuingCardEphemeralKeyProvider)
- @objc public init(keyProvider: any Stripe.STPIssuingCardEphemeralKeyProvider)
- @objc public var cardId: Swift.String {
- @objc public var certificates: [Foundation.Data] {
- @objc public var certificatesBase64: [Swift.String] {
- @objc public var nonce: Foundation.Data {
- @objc public var nonceHex: Swift.String {
- @objc public var nonceSignature: Foundation.Data {
- @objc public var nonceSignatureHex: Swift.String {
- @objc required public init(cardId: Swift.String, certificates: [Foundation.Data], nonce: Foundation.Data, nonceSignature: Foundation.Data)
- @objc(createCustomerKeyWithAPIVersion:completion:) func createCustomerKey(withAPIVersion apiVersion: Swift.String, completion: @escaping StripePayments.STPJSONResponseCompletionBlock)
- @objc(createIssuingCardKeyWithAPIVersion:completion:) func createIssuingCardKey(withAPIVersion apiVersion: Swift.String, completion: @escaping StripePayments.STPJSONResponseCompletionBlock)
- @objc(initWithRequestConfiguration:delegate:) @_Concurrency.MainActor @preconcurrency required public init?(requestConfiguration configuration: PassKit.PKAddPaymentPassRequestConfiguration, delegate: (any PassKit.PKAddPaymentPassViewControllerDelegate)?)
- public var apiClient: StripeCore.STPAPIClient
- public var apiClient: StripeCore.STPAPIClient
- }
- }
- }
- }
- }
- }
- }StripeIssuing+ @objc get
+ @objc get
+ @objc get
+ get
+ get
+ get
+ get
+ @_Concurrency.MainActor @preconcurrency @objc convenience override dynamic public init(nibName nibNameOrNil: Swift.String?, bundle nibBundleOrNil: Foundation.Bundle?)
+ @_Concurrency.MainActor @preconcurrency @objc override dynamic public func viewDidLoad()
+ @_Concurrency.MainActor @preconcurrency @objc required convenience dynamic public init?(coder aDecoder: Foundation.NSCoder)
+ @available(*, deprecated, renamed: "requestConfiguration(withName:description:last4:brand:primaryAccountIdentifier:)", message: "Use `requestConfiguration(withName:description:last4:brand:primaryAccountIdentifier:)` instead.")
+ @objc @_Concurrency.MainActor @preconcurrency public class func canAddPaymentPass() -> Swift.Bool
+ @objc @_Concurrency.MainActor @preconcurrency weak public var delegate: (any PassKit.PKAddPaymentPassViewControllerDelegate)?
+ @objc deinit
+ @objc deinit
+ @objc deinit
+ @objc public class func requestConfiguration(withName name: Swift.String, description: Swift.String?, last4: Swift.String?, brand: StripePayments.STPCardBrand) -> PassKit.PKAddPaymentPassRequestConfiguration
+ @objc public class func requestConfiguration(withName name: Swift.String, description: Swift.String?, last4: Swift.String?, brand: StripePayments.STPCardBrand, primaryAccountIdentifier: Swift.String?) -> PassKit.PKAddPaymentPassRequestConfiguration
+ @objc public func addPaymentPassViewController(_ controller: PassKit.PKAddPaymentPassViewController, generateRequestWithCertificateChain certificates: [Foundation.Data], nonce: Foundation.Data, nonceSignature: Foundation.Data, completionHandler handler: @escaping (PassKit.PKAddPaymentPassRequest) -> Swift.Void)
+ @objc public func retrievePin(_ cardId: Swift.String, verificationId: Swift.String, oneTimeCode: Swift.String, completion: @escaping StripePayments.STPPinCompletionBlock)
+ @objc public func updatePin(_ cardId: Swift.String, newPin: Swift.String, verificationId: Swift.String, oneTimeCode: Swift.String, completion: @escaping StripePayments.STPPinCompletionBlock)
+ @objc public init(keyProvider: any StripeIssuing.STPIssuingCardEphemeralKeyProvider)
+ @objc public init(keyProvider: any StripeIssuing.STPIssuingCardEphemeralKeyProvider)
+ @objc public var cardId: Swift.String {
+ @objc public var certificates: [Foundation.Data] {
+ @objc public var certificatesBase64: [Swift.String] {
+ @objc public var nonce: Foundation.Data {
+ @objc public var nonceHex: Swift.String {
+ @objc public var nonceSignature: Foundation.Data {
+ @objc public var nonceSignatureHex: Swift.String {
+ @objc required public init(cardId: Swift.String, certificates: [Foundation.Data], nonce: Foundation.Data, nonceSignature: Foundation.Data)
+ @objc(createCustomerKeyWithAPIVersion:completion:) func createCustomerKey(withAPIVersion apiVersion: Swift.String, completion: @escaping StripePayments.STPJSONResponseCompletionBlock)
+ @objc(createIssuingCardKeyWithAPIVersion:completion:) func createIssuingCardKey(withAPIVersion apiVersion: Swift.String, completion: @escaping StripePayments.STPJSONResponseCompletionBlock)
+ @objc(initWithRequestConfiguration:delegate:) @_Concurrency.MainActor @preconcurrency required public init?(requestConfiguration configuration: PassKit.PKAddPaymentPassRequestConfiguration, delegate: (any PassKit.PKAddPaymentPassViewControllerDelegate)?)
+ public var apiClient: StripeCore.STPAPIClient
+ public var apiClient: StripeCore.STPAPIClient
+ }
+ }
+ }
+ }
+ }
+ }
+ }If you are adding a new public API consider the following:
If you are modifying or removing a public API:
If you confirm these APIs need to be added/updated and have undergone necessary review, add the label ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with |
STPEphemeralKey.swift:14 warning: Property 'created' is assigned, but never used
STPPushProvisioningDetails.swift:13 warning: Property 'cardId' is assigned, but never usedThis dead code check has been bypassed with the ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with [find-dead-code] |
shu-stripe
changed the title
Added migration instructions for StripeIssuing component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved PushProvisioning code to StripeIssuing module and followed https://confluence.corp.stripe.com/spaces/MOBILE/pages/310463072/iOS+SDK+Runbook+Adding+module+dependencies to update dependencies.
Motivation
Move PushProvisioning to it's own module.
Testing
Changelog
Not a user facing change.