Skip to content

Conversation

@gbirch-stripe
Copy link
Collaborator

@gbirch-stripe gbirch-stripe commented Jan 7, 2026

Summary

Motivation

failedToMakeImageFromData error analytics are very noisy, potentially because they are frequently firing for non-2xx http statuses
https://jira.corp.stripe.com/browse/RUN_MOBILESDK-4975

Testing

Changelog

@gbirch-stripe gbirch-stripe requested review from a team as code owners January 7, 2026 18:18
@gbirch-stripe
Copy link
Collaborator Author

@wooj sanity checking that there's no situation in which we would want to proceed to attempt decoding of the image even though there is a non-2xx response?

@wooj-stripe
Copy link
Collaborator

@wooj sanity checking that there's no situation in which we would want to proceed to attempt decoding of the image even though there is a non-2xx response?

Maybe in a redirect situation (3xx) you could be sent another URL, in which case it could result to a 2xx. Perhaps some very creative enterprise firewall rules may lead to this situation?

@gbirch-stripe
Copy link
Collaborator Author

@wooj sanity checking that there's no situation in which we would want to proceed to attempt decoding of the image even though there is a non-2xx response?

Maybe in a redirect situation (3xx) you could be sent another URL, in which case it could result to a 2xx. Perhaps some very creative enterprise firewall rules may lead to this situation?

Hmm I'm not well familiarized with 3xx behavior on iOS. Do you know if the OS networking layer automatically handle the redirection, return the correct data, but still return the original 3xx? If you don't know I can also explore this deeper or just include 3xx in case

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

✅ Dead code has been resolved in this PR.

[find-dead-code]

@gbirch-stripe gbirch-stripe merged commit d48d5c2 into master Jan 9, 2026
8 checks passed
@gbirch-stripe gbirch-stripe deleted the gbirch/reduce-failedtomakeimagefromdata-false-positives branch January 9, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants