Draft
Conversation
sylane
reviewed
Mar 30, 2025
Contributor
There was a problem hiding this comment.
This is definitely a great addition, but looking at where you needed that for, wouldn't that be better to add configuration to better customise the default template ? Otherwise, instead of making the plugin more powerful and customisable, all the project will progressively use their own templates, then why wouldn't they use Dockerfile directly instead ?
Looking quickly at the custom templates you used It for, it seems the only extra config needed to be able to use the default template would be:
- Add way to extend the files copied into the builder (line 24) and maybe change the default template as it would make sense for it to include c_src, src, priv, config and optional _checkouts anyway.
- Add config to change the entry point, with the possibility to specify a custom script...
This PR is still very useful, but I am a bit worried that if a custom template is the easy way out of a missing feature, the plugin is kind of loosing its meaning.
| runtime_packages => [#{name => N} | ||
| || N <- maps:get(runtime_packages, Config)] | ||
| }. | ||
| template_file(RState, Config) -> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.