Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default controls to unsatisfied by not including satisfies: frontmatter in templates #85

Closed
wants to merge 1 commit into from
Closed

Conversation

joepurdy
Copy link

This is an alternate approach to #79 that would fix #77 in a backwards compatible manner.

Instead of changing to a new frontmatter format that requires a live property to satisfy controls this PR merely updates the template files to have the satisfies property commented out by default.

This has the effect that newly Comply generated compliance programs start by showing the 61 controls from TSC-2017.yaml as unsatisfied. The TODO.yml is also updated to reference a step in the customize policies phase for uncommenting the satisfies frontmatter.

I also removed the satisfies frontmatter altogether from templates where the TSC mapped is CC9.9. That's not a real criteria and seems to have been added as a placeholder. No sense in confusing people new to the TSC with fictitious listings.

@joepurdy
Copy link
Author

Doesn't look like Comply is being actively maintained. No need for lingering PRs so I'm going to close this off.

@joepurdy joepurdy closed this Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marking items un-satisfied
1 participant