Fix types minor errors #710
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Strophe and Connection types to export. It makes it easier to `import type { Connection } from 'strophe.js'`
jcbrand
reviewed
Jun 23, 2024
| @@ -37,7 +37,7 @@ import { $pres } from './builder.js'; | |||
| * @property {Object.<string, string>} NS | |||
| * @property {XHTML} XHTML | |||
| */ | |||
| export const Strophe: { | |||
| declare const Strophe: { | |||
There was a problem hiding this comment.
Did you make this change by hand? These files are autogenerated (by running make types).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
First of all thanks for your hard work on the v3.0.0 !
I recently updated the deps in a project I work on, and
tscprompted some minor TS errors from Strophe.So here is a quick PR to fix the errors encountered :
connection.jsandconnection.d.ts, at theaddHandlermethod, theidparameter should be optional since it is already optional inHandler.constructorindex.d.ts,StropheandConnectionwere added to the export, for simplicity purposesLet me know if you need any changes on the PR.
Best regards !