This repository was archived by the owner on Mar 22, 2023. It is now read-only.
C4PlantUmlWriter: Update with v2.2.0 tags and styles (and with EnableNextFeatures the v2.3.0 features)#6
Open
kirchsth wants to merge 7 commits intostructurizr:masterfrom
Conversation
- Update from netcoreapp 1.1 to netcoreapp 2.1 - Update from netstandard 1.3 to netstandard 2.0 - Structurizr.AdrTools: link use "%2F" instead of "/" (sync with java impl.) - C4PlantUML: -- Updated that it works with new calculated CanonicalName -- Test updated with new sample -- RelationshipView stores "DirectionValues" in Position (properties are not available anymore) -- !!! generated PlantUML itself is not updated (no new styles, ...)
….2.0 - all obsolete "C4_Dynamic" and "C4_Deployment" calls are removed - new SHOW_LEGEND() call is used (instead of LAYOUT_WITH_LEGEND) - new RelIndex() call is used (instead of Interact2) - new kirchsth extsions are stored in https://raw.githubusercontent.com/kirchsth/C4-PlantUML/extended (not master anymore) - new stdlib Node()-impl supports automatic line breaks (BlockText calculation is obsolete, no </size>\n<size:TECHN_FONT_SIZE>)
…2.2.0 - Update c4-plantuml.md docu
C4PlantUmlWriter - RelationshipView.Response (back calls) supported - DeplymentView supports SoftwareSystemInstances
…NextFeatures the v2.3.0 person shape; rounded boxes, dotted lines...)
Collaborator
|
Thanks! There's quite a lot going on here, and I don't have much time at the moment. How do you feel about splitting the Structurizr.PlantUML project off and hosting it your own repo? (with a view to removing it from here, and pointing people to your repo instead) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @simonbrowndotje,
I updated the C4PlantUmlWriter that it supports the new v2.2.0 features "Styles" and "Tags" too like
The option "EnableNextFeatures" enables features of the next planed version (v2.3.0 ?) too and the correct person shape, rounded boxes and dashed lines can be displayed.
Can you please check and merge it?
Thank you and best regards
Helmut
PS.: Atm I still store the "RelationshipView.SetDirection" in the "RelationshipView.Position" property, can you please reactivate the "Properties" that I can remove the workaround/hack and store it there?