Removes redundant spaces in single tokens with multiline separators #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now cases when a single keyword is split by multiple multiline separators are supported.
```structurizr
work\
spa\
ce {
}
```
Also fixes redundant spaces inside quoted strings. The following code was parsed as `"Soft ware System"` before.
```structurizr
"Soft\
ware \
Sys\
tem"
```
BREAKING CHANGE!
The following code produced valid workspace before, because whitespaces in the second line were preserved. Now the first three lines will produce a single token `workspace{`.
```structurizr
workspace\
\
{
}
```
goto1134
force-pushed
the
fix-multiple-multiline-separators-produce-redundant-whitepsaces
branch
from
4f8c7a0 to
927c641
Compare
|
@simonbrowndotje , could you please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now cases when a single keyword is split by multiple multiline separators are supported.
Also fixes redundant spaces inside quoted strings. The following code was parsed as
"Soft ware System"before.BREAKING CHANGE!
The following code produced valid workspace before, because whitespaces in the second line were preserved. Now the first three lines will produce a single token
workspace{.