Nx aws bcrypt layer example #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vespertilian
commented
Mar 21, 2021
vespertilian
commented
- Renamed all the apps to be namespaced as nx-aws-[lib_or_app] so if a user already has an api or frontend and they are testing the deploy it will not clash
- Update the docs with some diagrams.
studds
approved these changes
Mar 21, 2021
|
|
||
| Frontend: `ng serve simple` | ||
| Backend: `ng serve api` | ||
| The SAM backend (nx-aws-api) depends on two lambda layers. |
Owner
There was a problem hiding this comment.
In this example repo, I wonder if it's worth including both a simple example (app + api) and a complex example (with layers)? Possibly an example where a binary dep is included directly?
Author
There was a problem hiding this comment.
I think that's a good idea if we have the bandwidth, but I think in the first case the more complex example is better you can always delete the complexity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.