-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate PostInstall Laravel Prompts #348
Merged
robdekort
merged 15 commits into
studio1902:main
from
marcorieser:use-prompts-in-post-install-script
Nov 1, 2023
Merged
Migrate PostInstall Laravel Prompts #348
robdekort
merged 15 commits into
studio1902:main
from
marcorieser:use-prompts-in-post-install-script
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the population of language options based on the Laravel Lang package since the classes were not available when installing via CLI. Ended up with a similar approach to the current implementation. Just for the record (if we ever want to give it another shot to implement it): protected function selectLanguageToInstall(Collection $installedLanguages): string
{
return suggest(
label: 'Handle of language (submit empty when you\'re done)'
options: fn($value) => collect(\LaravelLang\Locales\Facades\Locales::raw()->available())
->filter(fn(string $language) => str_contains($language, $value) && !$installedLanguages->contains($language))
->values()
->toArray(),
validate: fn(string $value) => match (true) {
$value && !\LaravelLang\Locales\Facades\Locales::isAvailable($value) => 'Not supported by Laravel Lang.',
$value && $installedLanguages->contains($value) => "Language \"{$value}\" already installed."
default => null,
},
hint: $installedLanguages->isNotEmpty() ? 'Installed: ' . $installedLanguages->join(', ', ' and ') : '',
);
} |
This is awesome. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Use Laravel Prompts for PostInstall Script
Issues
LaravelLang
is not available after installation when using CLI. Used current implementation for now.statamic new project studio1902/statamic-peak
) (Laravel Prompts in Starter Kit not interactive statamic/cli#62). For now, we reapply the interaction state based on the passed options. But seems a bug in Prompts.