- 
                Notifications
    You must be signed in to change notification settings 
- Fork 20
          Contract-Call? arg repr tests
          #640
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand how those tests "ensure that function arguments are stored and handled correctly, particularly for memory allocation and representation consistency."
I understand that these tests are there to check the fix from stacks-network/stacks-core#6009, but here the fix is not applied yet. So if those tests don't fail with the current code, what are they supposed to show?
| Thank you for the feedback! The reason the tests are not failing is due to the current implementation over-allocating space for argument representations. These tests remain valid, as they are intended to verify the new implementation, which should allocate only the exact amount of space required. | 
- this ensures the argument is not altered and correctly handled
| I'm not super convinced here... | 
| 
 | 
This PR adds test coverage for the
contract-call?arguments representations in memory. These tests help ensure that function arguments are stored and handled correctly, particularly for memory allocation and representation consistency.Related PR: stacks-network/stacks-core#6009
Related Issue: #633