Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate stytch-node completely from API definitions + docs #229

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

logan-stytch
Copy link
Contributor

A fully codegen'd version of the stytch-node backend SDK based on parsed definitions from our API + docs from the official stytch.com/docs/api pages.

NOTE: Putting this up for discussion. It's possible that we'll want to change some things before we land this.

@logan-stytch logan-stytch marked this pull request as ready for review June 15, 2023 20:53
@logan-stytch logan-stytch requested a review from a team as a code owner June 15, 2023 20:53
@socket-security
Copy link

socket-security bot commented Jun 21, 2023

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Mild CVE semver 5.7.1 package-lock.json via @babel/[email protected]
Mild CVE semver 6.3.0 package-lock.json via @babel/[email protected], @babel/[email protected], @babel/[email protected], @babel/[email protected], [email protected], [email protected]
Mild CVE semver 7.0.0 package-lock.json via @babel/[email protected]
Mild CVE semver 7.3.5 package-lock.json via @typescript-eslint/[email protected], @typescript-eslint/[email protected], [email protected], [email protected], [email protected]

Next steps

What is a mild CVE?

Contains a low severity Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known low severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@logan-stytch logan-stytch temporarily deployed to integration_tests July 31, 2023 21:04 — with GitHub Actions Inactive
@logan-stytch logan-stytch temporarily deployed to integration_tests July 31, 2023 21:04 — with GitHub Actions Inactive
@logan-stytch logan-stytch temporarily deployed to integration_tests July 31, 2023 21:04 — with GitHub Actions Inactive
@logan-stytch logan-stytch temporarily deployed to integration_tests July 31, 2023 21:06 — with GitHub Actions Inactive
@logan-stytch logan-stytch temporarily deployed to integration_tests July 31, 2023 21:06 — with GitHub Actions Inactive
@logan-stytch logan-stytch temporarily deployed to integration_tests July 31, 2023 21:06 — with GitHub Actions Inactive
lib/b2b/organizations_members.ts Outdated Show resolved Hide resolved
trusted_metadata?: UserMetadata;
untrusted_metadata?: UserMetadata;
/**
* The phone number to use for one-time passcodes. The phone number should be in E.164 format. The phone
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment seems to be more a consequence of us reusing the same phone_number param in docs rather than being applicable to CreateUser. I think its fine for now but probably a bit out of context. For example, I think our CreateUser sandbox only checks for a sandbox email https://github.com/stytchauth/api/blob/main/pkg/middleware/sandbox/response/response.go#L108

@logan-stytch logan-stytch temporarily deployed to integration_tests August 1, 2023 20:32 — with GitHub Actions Inactive
@logan-stytch logan-stytch temporarily deployed to integration_tests August 1, 2023 20:32 — with GitHub Actions Inactive
@logan-stytch logan-stytch temporarily deployed to integration_tests August 1, 2023 20:32 — with GitHub Actions Inactive
@logan-stytch logan-stytch temporarily deployed to integration_tests August 2, 2023 21:17 — with GitHub Actions Inactive
@logan-stytch logan-stytch temporarily deployed to integration_tests August 2, 2023 21:17 — with GitHub Actions Inactive
@logan-stytch logan-stytch temporarily deployed to integration_tests August 2, 2023 21:17 — with GitHub Actions Inactive
Copy link
Contributor

@max-stytch max-stytch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all 19k lines of it. which I have reviewed. with my eyeballs.

@logan-stytch logan-stytch temporarily deployed to integration_tests August 3, 2023 20:59 — with GitHub Actions Inactive
@logan-stytch logan-stytch temporarily deployed to integration_tests August 3, 2023 20:59 — with GitHub Actions Inactive
@logan-stytch logan-stytch temporarily deployed to integration_tests August 3, 2023 20:59 — with GitHub Actions Inactive
@logan-stytch logan-stytch merged commit fe950be into main Aug 3, 2023
9 checks passed
@logan-stytch logan-stytch deleted the logan/revamp branch August 3, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants