Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [AUTH-1697] (BREAKING) Refactor authenticateJwt and authenticateJwtLocal to use request pattern #253

Merged
merged 4 commits into from
Oct 4, 2023
Merged

feat: [AUTH-1697] (BREAKING) Refactor authenticateJwt and authenticateJwtLocal to use request pattern #253

merged 4 commits into from
Oct 4, 2023

Conversation

max-stytch
Copy link
Contributor

Refactors authenticateJwt and authenticateJwtLocal manual methods to take in a request object. This is a breaking change, so DNM for now. We'll coordinate a breaking change with the dropping of Node 16 later this month.

@max-stytch max-stytch requested a review from a team as a code owner October 2, 2023 22:42
@linear
Copy link

linear bot commented Oct 2, 2023

AUTH-1697 Node Backend SDK

Add anauthorization_check field to the sessions.Authenticate, sessions.AuthenticateJWT, and sessions.AuthenticateJWTLocal functions, and add a function to pull in the policy document for the provided project, cache it locally, and refresh it periodically in the background - in the same manner that the current JWKS is refreshed.

jeremy-stytch
jeremy-stytch approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@jeremy-stytch jeremy-stytch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for whenever you're ready to publish the release

lib/b2b/sessions.ts Outdated Show resolved Hide resolved
lib/b2c/sessions.ts Outdated Show resolved Hide resolved
@max-stytch max-stytch mentioned this pull request Oct 3, 2023
Merged
@max-stytch max-stytch temporarily deployed to integration_tests October 4, 2023 20:35 — with GitHub Actions Inactive
@max-stytch max-stytch temporarily deployed to integration_tests October 4, 2023 20:35 — with GitHub Actions Inactive
@max-stytch max-stytch temporarily deployed to integration_tests October 4, 2023 20:35 — with GitHub Actions Inactive
@max-stytch max-stytch merged commit a4e209c into main Oct 4, 2023
13 checks passed
@max-stytch max-stytch deleted the max-auth-1697 branch October 4, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremy-stytch jeremy-stytch jeremy-stytch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-stytch @jeremy-stytch