Uptake TOTP and recovery code changes and docs #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taronish-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
taronish-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
dist/b2b/organizations_members.js
Outdated
| * @throws A {@link StytchError} on a non-2xx response from the Stytch API | ||
| * @throws A {@link RequestError} when the Stytch API cannot be reached | ||
| */ | ||
| totp(data, options) { |
There was a problem hiding this comment.
deleteTOTP? Also documentation?
There was a problem hiding this comment.
Yeah this one is super strange. even the object names are missing the DeleteMFA portion that is present in the protos. I can manually update but sdk-codegen might just wipe it again unless we can figure out why its like this. I think I should just manually rename, and then look into how why its not updating the same way the delete otp phone number endpoint
There was a problem hiding this comment.
@taronish-stytch - I can work with you tomorrow to figure out why codegen is doing weird things.
ollie-stytch
approved these changes
Jan 23, 2024
taronish-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
taronish-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.