Change OAuth token input name #308
Conversation
…ganizationsMembersOAuthProvidersProviderInformationRequest
jennifer-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
jennifer-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
| * Request type for `organizations.members.oauthProviders.google`, | ||
| * `organizations.members.oauthProviders.microsoft`. | ||
| */ | ||
| export interface B2BOrganizationsMembersOAuthProvidersMicrosoftRequest { |
There was a problem hiding this comment.
If we wanted, it seems we could keep this interface around (or have it trivially defined as equivalent to B2BOrganizationsMembersOAuthProvidersProviderInformationRequest) and mark it deprecated. Then it wouldn't be a breaking change, which would (a) give consumers who are affected time to update before we "break" them, and (b) avoid a breaking change for anyone not affected (including anyone not using TS in the first place).
There was a problem hiding this comment.
Yeah, this is reasonable. We just need a manual TYPES section with this definition (kind of like here).
There was a problem hiding this comment.
Sounds good, I'll try to do this for all of the backend SDKs
jennifer-stytch
force-pushed
the
jmccleary/change-oauth-token-input-name
branch
from
7cb1039
to
5c7a6cb
Compare
jennifer-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
jennifer-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
jennifer-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
jennifer-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
| @@ -80,8 +80,8 @@ export type { | |||
|
|
|||
| export type { | |||
| B2BOrganizationsMembersOAuthProvidersGoogleResponse, | |||
| B2BOrganizationsMembersOAuthProvidersMicrosoftRequest, | |||
There was a problem hiding this comment.
Hmm, is this generated too? It's not exporting the deprecated type.
There was a problem hiding this comment.
I think this is generated since I don't recall ever having to manually edit it - @logan-stytch do you know why it might not be exporting the type here?
There was a problem hiding this comment.
Oh wait, there's a section for exporting the manual types. I'll add it
|
|
||
| // MANUAL(ProviderInformationRequest)(TYPES) | ||
| /** | ||
| * @deprecated Since version 10.11.0. Please use B2BOrganizationsMembersOAuthProvidersProviderInformationRequest instead. |
There was a problem hiding this comment.
tiny nit
| * @deprecated Since version 10.11.0. Please use B2BOrganizationsMembersOAuthProvidersProviderInformationRequest instead. | |
| * @deprecated Since version 10.11.0. Please use {@link B2BOrganizationsMembersOAuthProvidersProviderInformationRequest} instead. |
jennifer-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
jennifer-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
We're renaming
B2BOrganizationsMembersOAuthProvidersMicrosoftRequesttoB2BOrganizationsMembersOAuthProvidersProviderInformationRequest, since it's used for more than just Microsoft OAuth. The old type is still left in to avoid a breaking change, but marked as deprecated.