Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for GitHub B2B OAuth, Cross-Org Passwords #344

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Adds support for GitHub B2B OAuth, Cross-Org Passwords #344

merged 4 commits into from
Oct 29, 2024

Conversation

jcook-stytch
Copy link
Contributor

@jcook-stytch jcook-stytch commented Oct 23, 2024 •
edited
Loading

  • Will bump the version before merging!

@jcook-stytch jcook-stytch requested a review from a team as a code owner October 23, 2024 01:22
@jcook-stytch jcook-stytch changed the title Adds support for GitHub B2B OAuth Adds support for GitHub B2B OAuth, Cross-Org Passwords Oct 29, 2024
jennifer-stytch
jennifer-stytch reviewed Oct 29, 2024
View reviewed changes
lib/b2b/passwords_email.ts
import { fetchConfig } from "../shared";
import { Member, Organization } from "./organizations";
import { MemberSession } from "./sessions";
import { MfaRequired } from "./mfa";
import { request } from "../shared";

export interface B2BPasswordsEmailDeleteRequest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgier-stytch what's this method that was deleted? Was this ever supported?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennifer-stytch - @max-stytch says it was never supported

@jcook-stytch jcook-stytch merged commit f42d1a3 into main Oct 29, 2024
11 checks passed
@jcook-stytch jcook-stytch deleted the jcook/github-b2b-oauth branch October 29, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-stytch jennifer-stytch jennifer-stytch left review comments

@bgier-stytch bgier-stytch bgier-stytch approved these changes

@mjiang-stytch mjiang-stytch Awaiting requested review from mjiang-stytch mjiang-stytch is a code owner automatically assigned from stytchauth/client-libraries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcook-stytch @jennifer-stytch @bgier-stytch