Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature nemo tutorial #120

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Feature nemo tutorial #120

wants to merge 5 commits into from

Conversation

jtneedels
Copy link
Contributor

@jtneedels jtneedels commented Jan 23, 2023

Adding NEMO tutorials, starting with inviscid wedge case. See addition of files to tutorial repo: su2code/Tutorials#37

Signed-off-by: jtneedels <[email protected]>
Signed-off-by: jtneedels <[email protected]>
@pr-triage pr-triage bot added the PR: draft label Jan 23, 2023
Signed-off-by: jtneedels <[email protected]>
Signed-off-by: jtneedels <[email protected]>
@pcarruscag
Copy link
Member

You need to change the .yml files for the dropdown menus
https://github.com/su2code/su2code.github.io/pull/103/files

Signed-off-by: jtneedels <[email protected]>
@jtneedels
Copy link
Contributor Author

Thanks @pcarruscag , PLTA, I think I addressed your comment above. Any other changes needed?

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but if the links point to new files you may want to merge the other PRs first

@pcarruscag
Copy link
Member

It the files are all in master, then merge this to master instead, and you can directly check if everything is ok

@jtneedels
Copy link
Contributor Author

Thanks Pedro, yeah links point to files that are being uploaded in a separate PR - I'll make sure that PR gets merged first then merge to master here.

## Goals

Upon completion of this tutorial, the user will be familar with performing a simulation of external, inviscid flow over a 2D geometry using the NEMO Euler solver. The specific geometry chosen for the tutorial is a 10 degree wedge. Consequently, the following capabilities of SU2 will be showcased in the tutorial:
- Steady, 2D thermochenical nonequilibrium Euler equations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a bullet mentioning using the native/mpp library here

TIME_DISCRE_FLOW= EULER_IMPLICIT
```

In general, users can choose from explicit or implicit time integration schemes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In general, users can choose from explicit or implicit time integration schemes.
In general, users can choose from any explicit or implicit time integration schemes in SU2.

@bigfooted
Copy link
Contributor

@jtneedels, are there still things to be done for this tutorial?

@jtneedels
Copy link
Contributor Author

@bigfooted Yeah, I think we actually want to switch to another test case for the tutorial - this case doesn't have great convergence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants