Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update to rs-ucan 0.4.0, implementing Ucan 0.10ish. #449

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

jsantell
Copy link
Contributor

Building off of ucan-wg/rs-ucan#105, temporarily targeting the GitHub branch.

Changes:

  • Provide None hasher to witnessed_by
  • Expiration can now be empty, handle
  • Use generate_capability() where appropriate
  • Facts are now always maps, key the link value under LINK_RECORD_FACT_NAME as "link" -- open to suggestions here, probably should be less generic than "link", though not completely noosphere-specific as these could be shared outside the nooverse

Rename:

  • Capability => CapabilityView
  • With => Resource
  • Action => Ability
  • Resource => ResourceUri
  • SphereAction => SphereAbility

Cargo.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Would approve but for git dependencies.

@jsantell jsantell force-pushed the ucan-capabilities branch 2 times, most recently from 2146dd0 to 9a13a29 Compare June 27, 2023 19:40
@cdata
Copy link
Collaborator

cdata commented Jun 28, 2023

@jsantell ucan and ucan-key-support updates are published. ucan = "0.4.0" and ucan-key-support = "0.1.7"

@jsantell jsantell changed the title feat: Update to rs-ucan X, implementing Ucan 0.10ish. feat: Update to rs-ucan 0.4.0, implementing Ucan 0.10ish. Jun 28, 2023
@jsantell
Copy link
Contributor Author

jsantell commented Jun 28, 2023

Updated, though homebrew servers seem down at the moment affecting the macos builds; edit: fixed now

@jsantell jsantell requested a review from cdata June 28, 2023 17:29
Copy link
Collaborator

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot! :shipit:

@cdata cdata merged commit 8b806c5 into main Jun 28, 2023
20 checks passed
@cdata cdata deleted the ucan-capabilities branch June 28, 2023 20:48
This was referenced Jun 28, 2023
@github-actions github-actions bot mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🌱 Done
Development

Successfully merging this pull request may close these issues.

2 participants