Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

feat: Initial MVP implementation of RocksDbStorage #623

Merged
merged 1 commit into from
Sep 13, 2023
Merged

feat: Initial MVP implementation of RocksDbStorage #623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/noosphere_apple_build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
with:
brew: protobuf cmake
- name: 'Cargo Build'
run: cargo build --package noosphere --release --locked --target ${{ matrix.target }}
run: cargo build --package noosphere --release --locked --target ${{ matrix.target }} --features rocksdb
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only thing that should be backed out before landing.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to back this out? We want this to be the default for iOS, right?

Thinking about this a little more: we probably want to make this part of the matrix that gets generated in this step. We should use rocksdb for iOS and the default (presumably sled) everywhere else so that we don't have to migrate orb-created desktop replicas just yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just decoupling the implementation from the "on" switch -- we could make it a part of the build matrix, or configure it in noosphere::platform

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK if it's possible to distinguish e.g., M2/iPad from M2/MacBook Air in this way. We may need to talk it over a little bit to figure out the safe path forward (or face coming up with a migration playbook for orb users).

- run: |
cd target/${{ matrix.target }}/release
- uses: actions/upload-artifact@v3
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/run_test_suite.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
ipfs_version: v0.17.0
run_daemon: true
- name: 'Run Rust native target tests'
run: cargo test --features test-kubo,helpers
run: cargo test --features test-kubo,helpers,performance
env:
NOOSPHERE_LOG: deafening

Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:
ipfs_version: v0.17.0
run_daemon: true
- name: 'Run Rust native target tests'
run: NOOSPHERE_LOG=deafening cargo test --features test-kubo,headers
run: NOOSPHERE_LOG=deafening cargo test --features test-kubo,headers,performance
run-test-suite-linux-c:
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -160,7 +160,7 @@ jobs:
shell: bash
- name: 'Run Rust headless browser tests'
working-directory: ./rust
run: CHROMEDRIVER=/usr/local/bin/chromedriver cargo test --target wasm32-unknown-unknown
run: CHROMEDRIVER=/usr/local/bin/chromedriver cargo test --target wasm32-unknown-unknown --features performance
shell: bash

run-test-suite-web-typescript:
Expand Down
Loading