Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Block editor should save when exiting editor #1041

Closed
Tracked by #214
gordonbrander opened this issue Dec 20, 2023 · 0 comments · Fixed by #1044
Closed
Tracked by #214

Block editor should save when exiting editor #1041

gordonbrander opened this issue Dec 20, 2023 · 0 comments · Fixed by #1044
Assignees
@gordonbrander
Labels
Bug Something isn't working

Comments

@gordonbrander
Copy link
Collaborator

In addition to saving on timeout and saving when keyboard is dismissed, we should be saving when exiting an editing session by swiping back or hitting the back button, or loading a new note.

Part of #214
@gordonbrander gordonbrander added the Bug Something isn't working label Dec 20, 2023
@gordonbrander gordonbrander self-assigned this Dec 20, 2023
@gordonbrander gordonbrander moved this from 🏔️ Icebox to 📚 Todo in Subconscious + Noosphere Dec 20, 2023
@gordonbrander gordonbrander mentioned this issue Dec 20, 2023
Open
12 tasks
@gordonbrander gordonbrander changed the title Block editor does not save when exiting editor Block editor should save when exiting editor Dec 20, 2023
@gordonbrander gordonbrander mentioned this issue Dec 20, 2023
Merged
@gordonbrander gordonbrander moved this from 📚 Todo to 🧑‍🌾 In Progress in Subconscious + Noosphere Dec 20, 2023
bfollington pushed a commit that referenced this issue Dec 21, 2023
@gordonbrander
Block editor: save when editor is backgrounded or un-presented (#1044)
428478e 
Fixes #1041

## Testing

Setup:

- Go to Settings > Developer > Block Editor, and turn on block editor.

Scenario 1:

- Create a new note or edit an existing note
- Type some text
- Swipe back

What should happen: note should be saved.

Scenario 2:

- Create a new note or edit an existing note
- Type some text
- Background the app

What should happen: note should be saved.
@github-project-automation github-project-automation bot moved this from 🧑‍🌾 In Progress to 🌱 Done in Subconscious + Noosphere Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gordonbrander gordonbrander

Labels
Bug Something isn't working
Projects
Subconscious + Noosphere
Status: 🌱 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Block editor: save when editor is backgrounded or un-presented subconsciousnetwork/subconscious
1 participant
@gordonbrander